Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support for fuzzy arrows from the analyzer #31637

Closed
bwilkerson opened this issue Dec 13, 2017 · 5 comments
Closed

Remove support for fuzzy arrows from the analyzer #31637

bwilkerson opened this issue Dec 13, 2017 · 5 comments
Assignees
@leafpetersen
Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P2 A bug or feature request we're likely to work on
Milestone
Dart2Beta4

Comments

@bwilkerson
Copy link
Member

This might be as simple as removing the flag 'dynamic is bottom' from use sites in the analyzer.
@bwilkerson bwilkerson added area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P1 A high priority bug; for example, a single project is unusable or has many test failures labels Dec 13, 2017
@bwilkerson bwilkerson mentioned this issue Dec 13, 2017
Closed
14 tasks
@devoncarew
Copy link
Member

@leafpetersen is working on this - he's added a hint, which will become an error. We can then remove support.

@leafpetersen
Copy link
Member

Tracking bug for the fuzzy arrow elimination is here: #29630

@devoncarew devoncarew added this to the 2.0-alpha2 milestone Jan 26, 2018
@devoncarew devoncarew modified the milestones: 2.0-alpha2, 2.0-beta1 Feb 8, 2018
@bwilkerson
Copy link
Member Author

Can this issue be closed?

@bwilkerson bwilkerson removed this from the 2.0-beta1 milestone Mar 20, 2018
@leafpetersen
Copy link
Member

Not quite, but very close. When internal code is green, I will delete the last bit of support for it.

@leafpetersen leafpetersen mentioned this issue Mar 23, 2018
Closed
32 tasks
@bwilkerson bwilkerson added this to the Dart2 Beta 4 milestone Mar 29, 2018
@bwilkerson bwilkerson added P2 A bug or feature request we're likely to work on and removed P1 A high priority bug; for example, a single project is unusable or has many test failures labels Mar 29, 2018
@dgrove
Copy link
Contributor

dgrove commented Apr 12, 2018

Any updates @leafpetersen ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leafpetersen leafpetersen

Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P2 A bug or feature request we're likely to work on
Projects
None yet
Milestone
Dart2Beta4
Development

No branches or pull requests
4 participants
@devoncarew @dgrove @bwilkerson @leafpetersen