Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PrivateMemberTest seems wrong #353

Closed
DartBot opened this issue Nov 5, 2011 · 5 comments
Closed

PrivateMemberTest seems wrong #353

DartBot opened this issue Nov 5, 2011 · 5 comments
Assignees
@karlklose
Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). P1 A high priority bug; for example, a single project is unusable or has many test failures

Comments

@DartBot
Copy link

DartBot commented Nov 5, 2011

This issue was originally filed by jimhug@google.com

To the best of my understanding, this test appears to be relying on static type check errors in order to perform properly as a negative test. I don't understand why this test is currently passing on the VM?

I believe that this test would be both more accurate and more useful if it used runtime checks instead of compile-time checks to verify the complicated inheritance behavior of "hidden" privates that it is trying to be testing.
@DartBot
Copy link
Author

DartBot commented Nov 8, 2011

This comment was originally written by drfibonacci@google.com

Added Area-VM, Triaged labels.

@kasperl
Copy link

kasperl commented Nov 9, 2011

The VM passes this test because it generates dynamic errors for all the lines marked with /// 0?:. This is actually a bug in the VM. I agree with the conclusion that this is a test that relies on static type errors and that it should be fixed.

@ghost
Copy link

ghost commented Nov 10, 2011

The VM 'passes' all _0x.dart tests because the first line in test() {} always throws a runtime exception .. correctly.

The test is broken for all _0x.dart generated files, and the reason is because PrivateMemberLibB.dart imports PrivateMemberTest.dart instead of PrivateMemberTest_0x.dart. This causes B's superclass A to be in a different library than class Test.

Set owner to @karlklose.
Removed Area-VM label.
Added Area-Test label.

@jmesserly
Copy link

Marked this as blocking #251.

@karlklose
Copy link
Contributor

Added Fixed label.

@DartBot DartBot added Type-Defect P1 A high priority bug; for example, a single project is unusable or has many test failures area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). labels Dec 6, 2011
nex3 pushed a commit that referenced this issue Aug 31, 2016
Merge pull request #353 from dart-lang/revert-319-closure-qualify
bdb1dc1 
Revert "Qualified exports and inheritance for Closure"
This was referenced Oct 29, 2020
Open
Closed
Closed
This was referenced Nov 5, 2020
Closed
Open
copybara-service bot pushed a commit that referenced this issue May 19, 2023
@devoncarew
[deps] rev async, csslib, fixnum, glob, html, http, http_multi_server…
027660f 
…, http_parser, leak_tracker, logging, markdown, matcher, mockito, shelf, source_map_stack_trace, tools

Revisions updated by `dart tools/rev_sdk_deps.dart`.

async (https://github.com/dart-lang/async/compare/d744058..96c29d0):
  96c29d0  2023-05-17  Goddchen  docs: fix typo in CancelableOperation.fromFuture(...) docs (#243)

csslib (https://github.com/dart-lang/csslib/compare/923edf0..b2b9b55):
  b2b9b55  2023-05-18  Devon Carew  address a regression in the compact output format (#183)
  1ff82fd  2023-05-15  Devon Carew  blast_repo fixes (#181)
  35bef7f  2023-05-11  Nate Bosch  Simplify TopLevelIncludes visitor (#180)
  c4e904c  2023-05-10  Devon Carew  rev for publishing (#179)
  c9e47d0  2023-05-10  Kevin Moore  Require Dart 2.19, latest lints, skin hanging test (#175)
  3976e6f  2023-05-10  Devon Carew  address an issue parsing font names (#168)
  a337a9a  2023-05-10  Devon Carew  fixed CssPrinter pretty print indent levels (#169)

fixnum (https://github.com/dart-lang/fixnum/compare/006a130..d9b9a2a):
  d9b9a2a  2023-05-17  Devon Carew  blast_repo fixes (#112)

glob (https://github.com/dart-lang/glob/compare/46403be..30f6aba):
  30f6aba  2023-05-17  Devon Carew  blast_repo fixes (#77)

html (https://github.com/dart-lang/html/compare/593d6f6..92eacab):
  92eacab  2023-05-17  Devon Carew  blast_repo fixes (#216)

http (https://github.com/dart-lang/http/compare/fb3b4be..d845560):
  d845560  2023-05-17  Devon Carew  blast_repo fixes (#933)

http_multi_server (https://github.com/dart-lang/http_multi_server/compare/d1fffed..a209cd5):
  a209cd5  2023-05-17  Devon Carew  blast_repo fixes (#55)

http_parser (https://github.com/dart-lang/http_parser/compare/5a33f5f..1ef3e56):
  1ef3e56  2023-05-17  Devon Carew  blast_repo fixes (#73)

leak_tracker (https://github.com/dart-lang/leak_tracker/compare/8ae200a..571c24a):
  571c24a  2023-05-18  Polina Cherkasova  Delete generate_diagrams.yaml (#67)
  f2029b6  2023-05-18  Devon Carew  blast_repo fixes (#66)
  474fd4f  2023-05-18  Polina Cherkasova  Separate testing. (#65)
  92a0b48  2023-05-17  Polina Cherkasova  Fixes to support G3. (#64)

logging (https://github.com/dart-lang/logging/compare/b75cba7..fa2486d):
  fa2486d  2023-05-18  Desislava Stefanova  Logger `onLevelChanged` notification (#138)

markdown (https://github.com/dart-lang/markdown/compare/6db8fc1..b951454):
  b951454  2023-05-18  Devon Carew  blast_repo fixes (#542)
  a714d95  2023-05-17  Zhiguang Chen  Fix delimiter row matching pattern for tables (#540)

matcher (https://github.com/dart-lang/matcher/compare/4dfd9ad..7e10117):
  7e10117  2023-05-18  Devon Carew  blast_repo fixes (#224)

mockito (https://github.com/dart-lang/mockito/compare/3fadd2d..28f174f):
  28f174f  2023-05-17  Ilya Yanok  Only check formatting with the stable SDK

shelf (https://github.com/dart-lang/shelf/compare/79e3cee..8793687):
  8793687  2023-05-18  dependabot[bot]  Bump actions/labeler from 4.0.2 to 4.0.3 (#353)
  2f1aefb  2023-05-18  Devon Carew  blast_repo fixes (#351)
  e1ca05d  2023-05-18  Devon Carew  Update no-response.yml (#349)

source_map_stack_trace (https://github.com/dart-lang/source_map_stack_trace/compare/09715f9..b83af01):
  b83af01  2023-05-18  Devon Carew  blast_repo fixes (#39)

tools (https://github.com/dart-lang/tools/compare/62c9604..49da4ca):
  49da4ca  2023-05-12  Polina Cherkasova  Add memory events. (#92)

Change-Id: I5cd1277e6df1d72f69569090d9a2381a2b81d5d0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/304460
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Auto-Submit: Devon Carew <devoncarew@google.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@karlklose karlklose

Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). P1 A high priority bug; for example, a single project is unusable or has many test failures
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jmesserly @kasperl @karlklose @DartBot