Unreadable error messages from VM

[peter-ahe-google]

Errors encountered while loading script: 'foo.dart': Error: line 6 pos 1: library handler failed: 'foo_implementation.dart': Error: line 8 pos 1: library handler failed: 'foo/bar.dart': Error: line 26 pos 3: identifier expected
  @­Override
  ^

source('foo/bar.dart');

^

import('foo_implementation.dart');

^

[DartBot]

This comment was originally written by drfibonacci@google.com

---

Added Area-VM, Triaged labels.

[iposva-google]

Removed the owner.

[a-siva]

Can you include the source text of test case you were running which resulted in this error.

[iposva-google]

Set owner to @peter-ahe-google.

[peter-ahe-google]

==> foo.dart <==
#library('foo');
#import('foo_implementation.dart');

==> foo_implementation.dart <==
#library('foo_implementation');
#source('bar.dart');

==> bar.dart <==
class Bar {
  @­Override
  void foo() {}
}

dart_bin foo.dart gives me:

Errors encountered while loading script: 'foo.dart': Error: line 2 pos 1: library handler failed: 'foo_implementation.dart': Error: line 2 pos 1: library handler failed: 'bar.dart': Error: line 2 pos 3: identifier expected
  @­Override
  ^

#source('bar.dart');
^

#import('foo_implementation.dart');
^

I had expected something like:

bar.dart:2:3: identifier expected
  @­Override
  ^

Or possibly:

bar.dart:2:3: identifier expected
  @­Override
  ^
foo_implementation.dart:2:1: sourced from here
#source('bar.dart');
^
foo.dart:2:1: imported from here
#import('foo_implementation.dart');
^

---

Removed the owner.

[iposva-google]

Issue #414 has been merged into this issue.

[iposva-google]

We should make sure to at least not limit the length of the message. When there is a very long hierarchy of imports we start cutting off the actual error.

---

Set owner to @a-siva.
Added Accepted label.

[iposva-google]

Set owner to @sgmitrovic.

[ghost]

Fixed a while ago (separate bug filed by floitsch). The errors are appended onto each other, so the first error is clearly visible in the beginning.

---

Added Fixed label.

[peter-ahe-google]

Yay. This is very nice! Thank you.