Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breakpoints aren't hit when files imported in bin/ use relative paths (not package: uris) #35860

Closed
DanTup opened this issue Feb 5, 2019 · 2 comments
Labels
area-language Dart language related items (some items might be better tracked at github.com/dart-lang/language).

Comments

@DanTup
Copy link
Collaborator

DanTup commented Feb 5, 2019

Moving this from Dart-Code/Dart-Code#1446 since I think it makes sense to have the info here even if it's decided not to do this.


@DanTup:

This seems to be caused by relative path imports from outside lib. Since the entry point is outside lib it isn't considered a package: URI, and therefore the relative path is also not a package: URI.

A quick workaround is to change your imports in your bin/ scripts to be package:yyy/xxx imports (I think this is probably the preferred way to write them anyway?).

@lrhn @peter-ahe-google before I start multiplying up breakpoints again, is there a better for for this in Dart? For example, could/should imports into a packages lib folder also be recognised and mapped to package: URIs (for the same reasons #33076 was done)?


@peter-ahe-google:

I think we can do something similar to #33076. It requires a minor tweak to the language specification, and @lrhn is running that by the rest of the language team.

@vsmenon
Copy link
Member

vsmenon commented Feb 11, 2019

@lrhn @peter-ahe-google - is there an open language issue for this?

@dgrove dgrove added the area-language Dart language related items (some items might be better tracked at github.com/dart-lang/language). label Feb 18, 2019
@DanTup
Copy link
Collaborator Author

DanTup commented Jun 6, 2023

This appears to have been fixed at some point, importing with "../lib/" is triggering breakpoints just fine.

@DanTup DanTup closed this as completed Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-language Dart language related items (some items might be better tracked at github.com/dart-lang/language).
Projects
None yet
Development

No branches or pull requests

3 participants