Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow code completion for methods that take a callback #3590

Closed
sethladd opened this issue Jun 12, 2012 · 4 comments
Closed

Allow code completion for methods that take a callback #3590

sethladd opened this issue Jun 12, 2012 · 4 comments
Assignees
Milestone

Comments

@sethladd
Copy link
Contributor

This web socket code:

var ws = new WebSocket("ws://localhost:1337/ws");
ws.on.close.add( /* here try to run code completion */ );

When you try to run code completion inside a method that takes a callback function, you get nothing. :(

It would be very helpful to know you you can pass in a function here, and that the function takes a Dynamic event object.

Thanks!

@jwren
Copy link
Member

jwren commented Jun 12, 2012

Added I/O milestone since Seth likes to dream.

Thanks Steve :)


Removed this from the M1 milestone.
Added this to the IO2012 milestone.

@stevemessick
Copy link
Contributor

Is that sample code correct? My version of WebSocket is quite different. Might be worth adding a bug about cross-library consistency, so that dart:io is similar to dart:html (unless my version is out-of-date).


cc @sethladd.

@sethladd
Copy link
Contributor Author

Yup, this came up again today. I used dart:html for the example in the main description. The way dart:io sets up callbacks in in WebSocket is different. I'll open a bug.

@stevemessick
Copy link
Contributor

Fixed in build 8808.
The first computer I built was based on the 8088 chip.


cc @clayberg.
Added Fixed label.

@sethladd sethladd added this to the IO2012 milestone Jun 18, 2012
copybara-service bot pushed a commit that referenced this issue Nov 11, 2022
Also removes package:oauth2 from DEPS (it is now vendored in pub).

See dart-lang/oauth2#137.

Changes:
```
> git log --format="%C(auto) %h %s" 65c7f3e..6ac42d7
 https://dart.googlesource.com/pub.git/+/6ac42d76 Use package:vendor to vendor package:tar and package:oauth2 (#3638)
 https://dart.googlesource.com/pub.git/+/817fcf13 blast_repo fixes (#3646)
 https://dart.googlesource.com/pub.git/+/738d963c blast_repo fixes (#3644)
 https://dart.googlesource.com/pub.git/+/a73598b5 Refactor HTTP retries (#3325) (#3590)
 https://dart.googlesource.com/pub.git/+/5527068c New command `dart pub cache preload` (#3636)

```

Diff: https://dart.googlesource.com/pub.git/+/65c7f3e528f3f9978c4330cbd471070f17370f65~..6ac42d7644dedfcc500147ab47886eecab4b1b38/
Change-Id: I6d2dffcac67b4bd1c1c91be952cca65c84d85493
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/269301
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
Reviewed-by: Jonas Jensen <jonasfj@google.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants