Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CFE: Support await in UI as code constructs #36277

Closed
kmillikin opened this issue Mar 20, 2019 · 3 comments
Closed

CFE: Support await in UI as code constructs #36277

kmillikin opened this issue Mar 20, 2019 · 3 comments
Assignees
@kmillikin
Labels
area-front-end Use area-front-end for front end / CFE / kernel format related issues. front-end-kernel P1 A high priority bug; for example, a single project is unusable or has many test failures
Milestone
Dart 2.3

Comments

@kmillikin
Copy link

The VM-specific async transformation needs to handle await and await for in the UI as code constructs in collection literals.
@kmillikin kmillikin added P1 A high priority bug; for example, a single project is unusable or has many test failures area-front-end Use area-front-end for front end / CFE / kernel format related issues. front-end-kernel labels Mar 20, 2019
@kmillikin kmillikin added this to the Dart2.3 milestone Mar 20, 2019
@kmillikin kmillikin self-assigned this Mar 20, 2019
@a-siva
Copy link
Contributor

a-siva commented Mar 20, 2019

I presume the failure

sivalinuxmach[sdk]>out/DebugX64/dart --enable-experiment=spread-collections tests/language_2/spread_collections/await_test.dart
NoSuchMethodError: The method '&' was called on null.
Receiver: null
Tried calling: &(7)
#0      Object.noSuchMethod (dart:core/runtime/lib/object_patch.dart:50:5)
#1      BinaryPrinter.visitVariableGet (package:kernel/binary/ast_to_binary.dart:1279:15)
#2      VariableGet.accept (package:kernel/ast.dart:2258:36)
#3      BinaryPrinter.writeNode (package:kernel/binary/ast_to_binary.dart:371:10)
#4      LimitedBinaryPrinter.writeNode (package:kernel/binary/limited_ast_to_binary.dart:56:11)
#5      BinaryPrinter.visitMethodInvocation (package:kernel/binary/ast_to_binary.dart:1384:5)
#6      MethodInvocation.accept (package:kernel/ast.dart:2857:36)

is related to this.

@kmillikin
Copy link
Author

@a-siva, it's likely. I've started to fix the async transformation.

@kmillikin
Copy link
Author

Proposed fix is at https://dart-review.googlesource.com/c/sdk/+/98339

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kmillikin kmillikin

Labels
area-front-end Use area-front-end for front end / CFE / kernel format related issues. front-end-kernel P1 A high priority bug; for example, a single project is unusable or has many test failures
Projects
None yet
Milestone
Dart 2.3
Development

No branches or pull requests
2 participants
@kmillikin @a-siva