Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multitests with multiple VMOptions are not deflaked #36304

Closed
sortie opened this issue Mar 22, 2019 · 0 comments
Closed

Multitests with multiple VMOptions are not deflaked #36304

sortie opened this issue Mar 22, 2019 · 0 comments
Assignees
Labels
area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes. P1 A high priority bug; for example, a single project is unusable or has many test failures type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@sortie
Copy link
Contributor

sortie commented Mar 22, 2019

When implementing support for tests with multiple VMOptions in the new workflow, requesting that test.py run such a test with a selector or --test-list wasn't implemented. That means tests such as standalone_2/io/dart_std_io_pipe_test/04/1 is not being deflaked properly and cause builds to fail due to flakes.

This should get fixed so tools/test.py --test-list standalone_2/io/dart_std_io_pipe_test/04/1 works properly. This would make the deflaking test.py run output results in results.json for such tests and deflaking would work properly.

@sortie sortie added P1 A high priority bug; for example, a single project is unusable or has many test failures area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes. type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) labels Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes. P1 A high priority bug; for example, a single project is unusable or has many test failures type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Development

No branches or pull requests

2 participants