Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please update dart_style to 1.2.5 #36361

Closed
munificent opened this issue Mar 27, 2019 · 2 comments
Closed

Please update dart_style to 1.2.5 #36361

munificent opened this issue Mar 27, 2019 · 2 comments
Assignees
@athomas
Labels
area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes. area-sdk Use area-sdk for general purpose SDK issues (packaging, distribution, …). P1 A high priority bug; for example, a single project is unusable or has many test failures
Milestone
Dart 2.3

Comments

@munificent
Copy link
Member

Greetings, Lords of infrastructure!

I have just released dart_style 1.2.5 which adds support for the new UI-as-code features and updates it to support analyzer 0.36.0. Could you be so kind as to roll it into the SDK along with the pre-built SDK?

Thank you!

cc @stereotype441 @kevmoo
@munificent munificent added the area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes. label Mar 27, 2019
@munificent munificent added this to the Dart2.3 milestone Mar 27, 2019
@kevmoo kevmoo added P1 A high priority bug; for example, a single project is unusable or has many test failures area-sdk Use area-sdk for general purpose SDK issues (packaging, distribution, …). labels Mar 27, 2019
@pq pq mentioned this issue Mar 29, 2019
Merged
@pq
Copy link
Member

pq commented Mar 29, 2019

Thanks @munificent !

@munificent
Copy link
Member Author

The first take on this had to be reverted, I think because it depended on analyzer changes that hadn't made it to the dev branch yet. Send out a new review to try again:

https://dart-review.googlesource.com/c/sdk/+/98442

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@athomas athomas

Labels
area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes. area-sdk Use area-sdk for general purpose SDK issues (packaging, distribution, …). P1 A high priority bug; for example, a single project is unusable or has many test failures
Projects
None yet
Milestone
Dart 2.3
Development

No branches or pull requests
4 participants
@kevmoo @munificent @pq @athomas