Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Field::is_nullable should copy assertion from Field::guarded_cid #36717

Closed
liamappelbe opened this issue Apr 23, 2019 · 0 comments
Closed

Field::is_nullable should copy assertion from Field::guarded_cid #36717

liamappelbe opened this issue Apr 23, 2019 · 0 comments
Assignees
@liamappelbe
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.

Comments

@liamappelbe
Copy link
Contributor

is_nullable has the same background compiler consistency issues as guarded_cid, so it should use the same assert.
@liamappelbe liamappelbe self-assigned this Apr 23, 2019
@devoncarew devoncarew added the area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. label Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@liamappelbe liamappelbe

Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@devoncarew @liamappelbe