Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub code navigation support #37418

Open
johnpryan opened this issue Jul 1, 2019 · 3 comments
Open

GitHub code navigation support #37418

johnpryan opened this issue Jul 1, 2019 · 3 comments
Labels
area-meta Cross-cutting, high-level issues (for tracking many other implementation issues, ...). type-enhancement A request for a change that isn't a bug

Comments

@johnpryan
Copy link
Contributor

GitHub uses github.com/github/semantic for code navigation (beta). It would be great to have Dart on the list of supported languages.

@bwilkerson
Copy link
Member

Agreed. Unfortunately the docs for semantic are not very encouraging:

... adding support for a new language is a nontrivial amount of work.

There's work being done at Microsoft to add a Kythe-like language service to support similar sorts of tooling (https://code.visualstudio.com/blogs/2019/02/19/lsif). This would be much easier to implement because we wouldn't need to re-write everything. I don't know whether GitHub has any plans to support this protocol.

@a-siva a-siva added type-enhancement A request for a change that isn't a bug area-meta Cross-cutting, high-level issues (for tracking many other implementation issues, ...). labels Jul 3, 2019
@davidmorgan
Copy link
Contributor

package:pedantic recommends omit_local_variable_types in large part because google internal tools make it easy enough to find types by following cross references.

It doesn't look like adding code navigation support is an easy thing to do; it does seem like it could give a lot of value. Please count 'reduces difference between external and internal development' as part of that value :)

@gnprice
Copy link
Contributor

gnprice commented Feb 5, 2023

Related newer issue: #50523

It sounds like what GitHub now asks for in order to support a given language is a tree-sitter parser for it, which is somewhat more encouraging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-meta Cross-cutting, high-level issues (for tracking many other implementation issues, ...). type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

5 participants