Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dart VM Support for NNBD #37479

Closed
6 of 7 tasks
aadilmaan opened this issue Jul 9, 2019 · 5 comments
Closed
6 of 7 tasks

Dart VM Support for NNBD #37479

aadilmaan opened this issue Jul 9, 2019 · 5 comments
Assignees
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. Epic NNBD Issues related to NNBD Release

Comments

@aadilmaan
Copy link
Contributor

aadilmaan commented Jul 9, 2019

Here is a list of items that need to get done for this:

Phase 1 will deal with supporting NNBD in weak mode (D28 milestone)

Phase 2 will deal with supporting NNBD with strong mode checks

Phase 3 will deal with NNBD performance/code size issues

Links:
NNBD specification
NNBD in Dart VM
dart-vm-nnbd-tracking

@aadilmaan aadilmaan added the area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. label Jul 9, 2019
@aadilmaan aadilmaan added the Epic label Jul 9, 2019
@mkustermann
Copy link
Member

The CFE team has started working on non-nullable types and late fields. See the NNBD feature specification for more information. Both of those features will require VM support.

@a-siva The VM work could probably start soon on this, even if the CFE is not done.

@johnniwinther
Copy link
Member

johnniwinther commented Aug 12, 2019

Serialization of nullability just landed (https://dart-review.googlesource.com/c/sdk/+/112085). The values are still not added to types during parsing, though, so nothing is set yet (CFE issue #37811).

@mkustermann
Copy link
Member

@a-siva okrs mention @aartbik / @liamappelbe might be looking at the new language features, is that still the plan?

/cc @leafpetersen

@a-siva
Copy link
Contributor

a-siva commented Aug 20, 2019

@kustermann to answer your question above, @crelier is going to start working on the initial phase of this (accounting for non nullable types in the VM type system representation and type checks). A second phase of this would be to use the type information to potentially eliminate runtime null checks which generating code.

@aadilmaan aadilmaan added the NNBD Issues related to NNBD Release label Sep 3, 2019
dart-bot pushed a commit that referenced this issue Dec 10, 2019
This means that when snapshots are loaded, the nnbd experiment flag they
were compiled with must match the flag the VM currently has.

Bug: #37479
Change-Id: I907a68f49c7c1ac4467c4c39ce033075eba457a1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127961
Reviewed-by: Régis Crelier <regis@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>
@a-siva
Copy link
Contributor

a-siva commented May 9, 2020

Closing this as we have another Epic #41131 tracking the samething.

@a-siva a-siva closed this as completed May 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. Epic NNBD Issues related to NNBD Release
Projects
None yet
Development

No branches or pull requests

4 participants