Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation of NNBD strong checking mode in the VM #38845

Closed
liamappelbe opened this issue Oct 11, 2019 · 4 comments
Closed

Implementation of NNBD strong checking mode in the VM #38845

liamappelbe opened this issue Oct 11, 2019 · 4 comments
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. NNBD Issues related to NNBD Release vm-nnbd-sdk-complete All new NNBD and ported NNBD tests pass

Comments

@liamappelbe
Copy link
Contributor

liamappelbe commented Oct 11, 2019 •
edited by a-siva
Loading

Support the strong nullability checking modes in the VM.

The strong checking mode is set globally via a command line flag (this flag doesn't exist yet). The checks also depend on whether a library is opted in or not. We also want to support a debugging mode that mixes weak and strong, aborting if the weak check passes but the strong check fails (to help users migrate their libraries).

Part of #37479

Dependent issues -

Migrate "dart:profiler" tests to NNBD #40142
Migrate "dart:developer" tests to NNBD #40140
Migrate "dart:typed_data" tests to NNBD #40139
Migrate "dart:convert" tests to NNBD #40138
Expect.type([null] is! List) fails on Instance(length:1) of '_GrowableList' #39820
@liamappelbe liamappelbe added area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. NNBD Issues related to NNBD Release labels Oct 11, 2019
@a-siva a-siva changed the title Weak and Strong checking modes in the VM Implementation of NNBD Strong checking modes in the VM Dec 12, 2019
@aadilmaan aadilmaan mentioned this issue Dec 12, 2019
Closed
7 tasks
@a-siva a-siva changed the title Implementation of NNBD Strong checking modes in the VM Implementation of NNBD strong checking mode in the VM Dec 12, 2019
@a-siva a-siva added the vm-nnbd-sdk-complete All new NNBD and ported NNBD tests pass label Jan 16, 2020
@franklinyow franklinyow mentioned this issue Jan 16, 2020
Closed
dart-bot pushed a commit that referenced this issue Feb 25, 2020
@alexmarkov
[vm/nnbd] Add --null-safety option to VM's kernel compilers
aa2c1a4 
This change adds --null-safety option to the front-end server and
gen_kernel tools. This option is forwarded to CFE via
CompilerOptions.nnbdMode.

Issue: #38845

Change-Id: I410b1d5466d93d9514cb7571bf37b32c848f136c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137106
Reviewed-by: Régis Crelier <regis@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
dart-bot pushed a commit that referenced this issue Feb 25, 2020
@alexmarkov
[vm/nnbd] Rename --strong-non-nullable-type-checks to --null-safety a…
55cc495 
…nd pass it to CFE

Issue: #38845
Change-Id: I9baeb4a384a6b2de79df9f97e82c127ae4f611c0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137120
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
Reviewed-by: Liam Appelbe <liama@google.com>
dart-bot pushed a commit that referenced this issue Feb 27, 2020
@alexmarkov
[vm/nnbd] Type testing stubs in NNBD strong mode
77e1c72 
Issue: #38845
Change-Id: I82e7a1b3c4220abdd2a215529230fbb158adbe9e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/135627
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
@a-siva
Copy link
Contributor

a-siva commented Mar 11, 2020

Can nthis issue be closed as done?

@a-siva
Copy link
Contributor

a-siva commented Mar 20, 2020

@crelier @liamappelbe can this issue be marked closed, all the sub issues listed in the description are closed.

@liamappelbe
Copy link
Contributor Author

My parts are done. If @crelier is done too then we can close it.

@crelier
Copy link
Contributor

crelier commented Mar 20, 2020

I am not aware of any missing feature. It's only bug fixing from now on. Closing.

@crelier crelier closed this as completed Mar 20, 2020
tekknolagi pushed a commit to tekknolagi/dart-assembler that referenced this issue Nov 3, 2020
@alexmarkov
[vm/nnbd] Type testing stubs in NNBD strong mode
0b91681 
Issue: dart-lang#38845
Change-Id: I82e7a1b3c4220abdd2a215529230fbb158adbe9e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/135627
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. NNBD Issues related to NNBD Release vm-nnbd-sdk-complete All new NNBD and ported NNBD tests pass
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@liamappelbe @crelier @a-siva