Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all VM sources pass clang-tidy checks #38196

Open
1 task
mkustermann opened this issue Sep 4, 2019 · 2 comments
Open
1 task

Make all VM sources pass clang-tidy checks #38196

mkustermann opened this issue Sep 4, 2019 · 2 comments
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable

Comments

@mkustermann
Copy link
Member

mkustermann commented Sep 4, 2019

This is a tracking bug for ensuring all VM source pass clang-tidy checks.

Consider also adding more flags to the compiler:

  • -Wconversion
@mkustermann mkustermann added the area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. label Sep 4, 2019
@rmacnak-google rmacnak-google added the type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable label Sep 4, 2019
@rmacnak-google
Copy link
Contributor

See also #11526

@mkustermann
Copy link
Member Author

Over time I think we can add more and more checks.

If there are fine grained flags for the compiler itself we should use them and otherwise we can use the clang-tidy linter.

(e.g. Some bugs have been introduced in the past due to uninitialized fields. Getting the compiler error on those can be done via -Weffc++ - though that enables a lot more than we actually want)

@mkustermann mkustermann reopened this Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable
Projects
None yet
Development

No branches or pull requests

2 participants