Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

number comparisons are inconsistent #4018

Closed
floitschG opened this issue Jul 6, 2012 · 7 comments
Closed

number comparisons are inconsistent #4018

floitschG opened this issue Jul 6, 2012 · 7 comments
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. closed-obsolete Closed as the reported issue is no longer relevant core-2 library-core P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@floitschG
Copy link
Contributor

When comparing doubles and integers (one each) we currently always convert the integer to double. This doesn't make sense when integers are bigger than 2^53.
In this case the integers should always be greater than the double (except for double.INFINITY).
@floitschG
Copy link
Contributor Author

Correction (as Lasse correctly points out):
For doubles greater than 2^53 we should convert the double to integer.

@floitschG
Copy link
Contributor Author

Added Ready-to-implement label.

@andersjohnsen
Copy link

cc @floitschG.
Set owner to @Skabet.
Added Started label.

@lrhn
Copy link
Member

lrhn commented Apr 24, 2014

Added Library-Core label.

@andersjohnsen
Copy link

Removed the owner.
Added Triaged label.

@lrhn
Copy link
Member

lrhn commented Oct 10, 2014

CL was: https://codereview.chromium.org/27314003/
It is probably stale by now.
This still needs to be fixed.

@lrhn
Copy link
Member

lrhn commented Mar 16, 2015

Removed Ready-to-implement label.
Added Spec-Violation label.

@floitschG floitschG added Type-Defect area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-core labels Mar 16, 2015
@kevmoo kevmoo added P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed triaged labels Feb 29, 2016
@lrhn lrhn added the core-m label Aug 11, 2017
@floitschG floitschG added core-2 and removed core-m labels Aug 31, 2017
@lrhn lrhn mentioned this issue Jan 17, 2018
Closed
@matanlurey matanlurey added the closed-obsolete Closed as the reported issue is no longer relevant label Jun 19, 2018
@lrhn lrhn mentioned this issue Feb 3, 2021
Open
@lrhn lrhn reopened this Feb 3, 2021
@lrhn lrhn removed the closed-obsolete Closed as the reported issue is no longer relevant label Feb 3, 2021
@lrhn lrhn closed this as completed Feb 3, 2021
@lrhn lrhn added the closed-obsolete Closed as the reported issue is no longer relevant label Feb 3, 2021
@lrhn lrhn mentioned this issue Jan 13, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. closed-obsolete Closed as the reported issue is no longer relevant core-2 library-core P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@kevmoo @andersjohnsen @matanlurey @lrhn @floitschG