"Create missing overrides" fix creates incorrect linkedEditGroups, causing invalid code

[DanTup]

Moving this from Dart-Code/Dart-Code#2307 as it looks like a server issue. I can repro in both VS Code and Android Studio, though only in a Flutter project, not using the Dart SDK directly (I can't explain this bit, but I tried with a few recent Flutter SDKs and the latest dev + nightly Dart SDK, and it occurred only in the Flutter projects).

In a Flutter project, create a file with the following code:

import 'package:meta/meta.dart';

class MyTestClass {
  void verifyPhoneNumber({
    @required String phoneNumber,
    @required Duration timeout,
  }) {}

  Future<void> signInWithCustomToken({@required String token}) async {}
}

class A implements MyTestClass {}

Invoke "create 2 missing overrides" on class A and you'll end up with code like:

class A implements MyTestClass {
  @override
  Future<void> signInWithCustomToken({String token}) {
      // TODO: implement signInWithCustomToken
      throw UnimplementedError();
    }
  
    @override
    void verifyPhoneNumber({String token}) {      // <-- these last few characters are invalid
   , Duration timeout}) {
    // TODO: implement verifyPhoneNumber
  }
}

This seems to occur, because linkedEditGroups are generated that bundle String from both methods together, and also the arguments token and phoneNumber together - but they have only a single length per group, so the length of phoneNumber is applied to token which results in some unwanted characters:

{
	"positions": [
		{
			"file": "/Users/danny/Dev/Google/flutter/examples/flutter_gallery/lib/2307.dart",
			"offset": 321
		},
		{
			"file": "/Users/danny/Dev/Google/flutter/examples/flutter_gallery/lib/2307.dart",
			"offset": 458
		}
	],
	"length": 11,     // This 11 is only correct for one of the offsets above, the other has a length of 6
	"suggestions": []
},

[DanTup]

Hit this with a simpler repro today. What I can't figure out, is why it only occurs in a Flutter project. If I use the exact same Dart SDK (from the flutter/bin/cache/dart-sdk) in a Dart project, it generates the correct code.

class Foo extends Bar {}

abstract class Bar {
  void update(double t);
  void render(String c);
}

Run "Create missing overrides" on Foo, and in a Flutter project it'll use String for both args but in a Dart project it'll correctly use double for one of them.

[DanTup]

@bwilkerson this seems to be coming up quite a bit lately - not sure if you've seen this though, as it hasn't been tagged as much as other analyzer issues.

I haven't been able to figure out why it only seems to happen in Flutter projects, doesn't seem like that should affect something like this.

[DanTup]

This has been fixed (#42468).

[proninyaroslav]

Also encountered this problem (VSCode).

class ShipmentActivityInfo {}

abstract class ShipmentRepository {
  Future<void> addActivities(List<ShipmentActivityInfo> activities);

  Future<void> deleteActivitiesByTrack(String trackNumber);

  Future<List<ShipmentActivityInfo>> getActivitiesByTrack(String trackNumber);
}

class ShipmentRepositoryImpl extends ShipmentRepository {}