Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please merge #2cf981f354e15a9a88cec0b5c534c01aa55828c9 into dev channel #41550

Closed
mkustermann opened this issue Apr 17, 2020 · 4 comments
Closed

Please merge #2cf981f354e15a9a88cec0b5c534c01aa55828c9 into dev channel #41550

mkustermann opened this issue Apr 17, 2020 · 4 comments
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. cherry-pick-approved Label for approved cherrypick request cherry-pick-review Issue that need cherry pick triage to approve merge-to-beta

Comments

@mkustermann
Copy link
Member

commit(s) to merge: 2cf981f

merge instructions: git cherry-pick 2cf981f354e15a9a88cec0b5c534c01aa55828c9

reason: Makes VM no longer segfault during hot-reload (in common cases, which flutter users are hitting). See #41482 . There might be follow-up work to handle the issue better, but this change makes the situation already much better

/cc @dgrove @kevmoo @mit-mit @whesse @athomas
@mkustermann mkustermann added area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. merge-to-dev labels Apr 17, 2020
@mkustermann
Copy link
Member Author

/cc @rmacnak-google

@mkustermann mkustermann added merge-to-beta cherry-pick-review Issue that need cherry pick triage to approve and removed merge-to-dev labels Apr 17, 2020
@mkustermann
Copy link
Member Author

@franklinyow I tentatively added the merge-to-beta label as well.

@franklinyow
Copy link
Contributor

cherrypick approved

@athomas
Copy link
Member

athomas commented Apr 20, 2020

Merged into beta with 91f39d8 (2.8.0-20.10.beta).

@athomas athomas closed this as completed Apr 20, 2020
@franklinyow franklinyow added the cherry-pick-approved Label for approved cherrypick request label Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. cherry-pick-approved Label for approved cherrypick request cherry-pick-review Issue that need cherry pick triage to approve merge-to-beta
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mkustermann @athomas @franklinyow