Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APIs in dart:html need to be fixed based on results from native null assertions #43683

Open
srujzs opened this issue Oct 5, 2020 · 0 comments
Assignees
Labels
area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. library-html web-libraries Issues impacting dart:html, etc., libraries

Comments

@srujzs
Copy link
Contributor

srujzs commented Oct 5, 2020

For context, #42536 and #42535 added a flag to both dart2js and ddc to check that dart:html and similar libraries' native APIs are sound. Currently, they are being tested internally in google3 to ensure their correctness. There are several observed instances where a native API returns a nullable (either due to the API being undefined/incompatible or because it actually returns null), but is typed as non-nullable. dart:html needs to be fixed to account for this discrepancy. This bug tracks work around those fixes.

Similarly, as libraries migrate to sound null-safety they may need to work around this limitation by casting the return values from these APIs as nullable even though they are actually non-nullable. When those APIs are fixed, those workarounds should be removed.

@srujzs srujzs added web-libraries Issues impacting dart:html, etc., libraries library-html area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. labels Oct 5, 2020
@srujzs srujzs self-assigned this Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. library-html web-libraries Issues impacting dart:html, etc., libraries
Projects
None yet
Development

No branches or pull requests

1 participant