Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Dart SDK samples to null safety #43711

Closed
2 tasks
alexmarkov opened this issue Oct 7, 2020 · 1 comment
Closed
2 tasks

Migrate Dart SDK samples to null safety #43711

alexmarkov opened this issue Oct 7, 2020 · 1 comment
Assignees
@alexmarkov
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. NNBD Issues related to NNBD Release P2 A bug or feature request we're likely to work on type-task A well-defined stand-alone task

Comments

@alexmarkov
Copy link
Contributor

https://github.com/dart-lang/sdk/tree/master/samples contains sample code which should be migrated to null safety.
We should probably do that when enabling non-nullable experiment by default.

There are 2 categories of samples:
@alexmarkov alexmarkov added area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. NNBD Issues related to NNBD Release labels Oct 7, 2020
@alexmarkov
Copy link
Contributor Author

These samples include tests which are currently failing on NNBD bots:

samples/ffi/async/async_test
samples/ffi/resource_management/resource_management_test
samples/ffi/samples_test
samples/ffi/sqlite/test/sqlite_test
samples/sample_extension/test/sample_extension_app_snapshot_test
samples/sample_extension/test/sample_extension_test

@alexmarkov alexmarkov mentioned this issue Oct 7, 2020
Closed
@a-siva a-siva added type-task A well-defined stand-alone task P2 A bug or feature request we're likely to work on labels Oct 28, 2020
@alexmarkov alexmarkov self-assigned this Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexmarkov alexmarkov

Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. NNBD Issues related to NNBD Release P2 A bug or feature request we're likely to work on type-task A well-defined stand-alone task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@a-siva @alexmarkov