Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDC debugger_test.dart golden test is broken #44025

Closed
vsmenon opened this issue Nov 2, 2020 · 0 comments
Closed

DDC debugger_test.dart golden test is broken #44025

vsmenon opened this issue Nov 2, 2020 · 0 comments
Labels
area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. P4 web-dev-compiler

Comments

@vsmenon
Copy link
Member

vsmenon commented Nov 2, 2020

The test tests/dartdevc[_2]/debugger/debugger_test.dart tests custom formatting logic used in chrome and has been broken for a long while. It includes a golden file comparison - although there are two copies of the test, both point at the same golden: tests/dartdevc_2/debugger/debugger_test_golden.txt.

As best as I can tell, this golden isn't properly read (falls back to null) when run on the bots or locally. It also appears that the actual string varies on different platforms.

For now, I'll resurrect the rest of the test (which would have caught #43987) and skip the golden check.

Note, custom formatters are on the way out, so we may preferred ripping this out instead of fully fixing.

@sigmundch @nshahan @jacob314

@vsmenon vsmenon added web-dev-compiler P4 area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. labels Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. P4 web-dev-compiler
Projects
None yet
Development

No branches or pull requests

1 participant