Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use type parser in legacy upper bound tests #44094

Closed
chloestefantsova opened this issue Nov 6, 2020 · 1 comment
Closed

Use type parser in legacy upper bound tests #44094

chloestefantsova opened this issue Nov 6, 2020 · 1 comment
Assignees
@chloestefantsova
Labels
area-front-end Use area-front-end for front end / CFE / kernel format related issues.

Comments

@chloestefantsova
Copy link
Contributor

Tests in pkg/front_end/test/fasta/types/legacy_upper_bound_helper.dart don't use the type parser from pkg/kernel/lib/testing/type_parser_environment.dart like it's done, for example, in pkg/kernel/test/norm_test.dart. The legacy upper bound tests should be rewritten using the type parser, so it's easier to add more tests and also easier to read them.
@chloestefantsova chloestefantsova added the area-front-end Use area-front-end for front end / CFE / kernel format related issues. label Nov 6, 2020
@chloestefantsova chloestefantsova self-assigned this Nov 6, 2020
@chloestefantsova
Copy link
Contributor Author

The issue is being worked on at https://dart-review.googlesource.com/c/sdk/+/170698.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chloestefantsova chloestefantsova

Labels
area-front-end Use area-front-end for front end / CFE / kernel format related issues.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chloestefantsova