Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable breakpoints #45336

Closed
bkonyi opened this issue Mar 16, 2021 · 3 comments
Closed

Add option to disable breakpoints #45336

bkonyi opened this issue Mar 16, 2021 · 3 comments
Assignees
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. vm-debugger

Comments

@bkonyi
Copy link
Contributor

bkonyi commented Mar 16, 2021

We should provide a service RPC to allow for enabling and disabling breakpoints without having to remove and recreate them each time.

VM tracking issue for flutter/devtools#696.

@bkonyi bkonyi added area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. vm-debugger labels Mar 16, 2021
@bkonyi bkonyi self-assigned this Mar 16, 2021
@a-siva
Copy link
Contributor

a-siva commented Mar 16, 2021

Why does this have to go in at the service RPC level, can this not be functionality handled by DDS ?

@bkonyi
Copy link
Contributor Author

bkonyi commented Mar 16, 2021

This would be simpler to add to the service since we already have a way to enable/disable breakpoints in the VM, it's just functionality that isn't currently exposed.

@a-siva
Copy link
Contributor

a-siva commented Mar 16, 2021

I was wondering about whether you would provide the capability of multiple clients to have their own enable/disable state for the breakpoints in which case the VM state would not help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. vm-debugger
Projects
None yet
Development

No branches or pull requests

2 participants