Failures on [vm/compiler] Assign deopt id to all allocation instructions...[vm/compiler] Always allow CSE of LoadStaticField & loosen assertion in AllowsCSE

[sstrickl]

There are new test failures on [vm/compiler] Assign deopt id to all allocation instructions...[vm/compiler] Always allow CSE of LoadStaticField & loosen assertion in AllowsCSE.

The tests

co19/LanguageFeatures/nnbd/late_A06_t05 Crash (expected Pass)
co19/LanguageFeatures/nnbd/weak/late_A06_t05 RuntimeError (expected Pass)
language/nnbd/syntax/late_modifier_global_var_test Crash (expected Pass)
language/nnbd/syntax/late_modifier_global_var_test RuntimeError (expected Pass)
language/nnbd/syntax/late_modifier_static_final_field_test Crash (expected Pass)
language/nnbd/syntax/late_modifier_static_final_field_test RuntimeError (expected Pass)

are failing on configurations

dartkp-strong-linux-release-x64
dartkp-weak-asserts-linux-release-x64

Example excerpt from logs:

stderr:
../../runtime/vm/runtime_entry.cc: 244: error: hit null error with cid 147, caller context: [sp+0] 00007f89d0008441(0000345b00930118), [sp+1] 00007f89d04e9cb1(352e972e004e0238), [sp+2] 000000000000000e, [sp+3] 0000000000000007, [sp+4] 0000000000000003, [sp+5] 0000000000000028, [sp+6] 0000000000000006
version=2.13.0-edge.6a585a20899ffa6e1598281730fc61b20348bd81 (be) (Wed Mar 24 11:55:44 2021 +0000) on "linux_x64"
pid=27657, thread=27660, isolate_group=main(0x5581e8488300), isolate=main(0x5581e8489800)
isolate_instructions=7f89d03bf000, vm_instructions=7f89d03bb000
  pc 0x00005581e737e3ac fp 0x00007f89cfb7e460 dart::Profiler::DumpStackTrace(void*)+0x7c
  pc 0x00005581e715f1c4 fp 0x00007f89cfb7e540 dart::Assert::Fail(char const*, ...)+0x84
  pc 0x00005581e73b009a fp 0x00007f89cfb7e5b0 out/ReleaseX64/dart_precompiled_runtime+0x75409a
  pc 0x00005581e73b020b fp 0x00007f89cfb7e720 dart::DRT_DispatchTableNullError(dart::NativeArguments)+0x16b
  pc 0x00007f89d03bceaa fp 0x00007f89cfb7e750 /b/s/w/ir/out/ReleaseX64/generated_compilations/dartkp-strong-linux-release-x64/tests_language_nnbd_syntax_late_modifier_global_var_test/out.aotsnapshot+0x2eaa
  ...

cc @mkustermann

[mkustermann]

Have reverted the CSE change in cl/192922