Failures on [co19] skip test that uses dart:mirrors on precompiled and web platforms

[aam]

There are new test failures on [co19] skip test that uses dart:mirrors on precompiled and web platforms.

The tests

pkg/dev_compiler/test/expression_compiler/expression_compiler_test Timeout (expected Pass)
pkg/dev_compiler/test/expression_compiler/expression_compiler_worker_test Timeout (expected Pass)

are failing on configurations

unittest-asserts-debug-linux

[sigmundch]

sounds like these tests are timing out flakily but not reaching the threshold of the bot infrastructure to be considered flaky.

@annagrin @Markzipan - it may be necessary to extend the default limit, or to split the test in several sub tests to stay within the timeout limit.

[Markzipan]

I'm currently porting the vast majority of of those tests to the e2e test suite. I can delete these tests from the regular suite, then split the ported tests if those grow too large.

[annagrin]

@aam could you please share a link to failures - I couldn't find them on that CL.

[aam]

@annagrin here you go: https://ci.chromium.org/ui/p/dart/builders/ci.sandbox/pkg-linux-debug/10144/overview

[alexmarkov]

pkg/dev_compiler/test/expression_compiler/expression_compiler_worker_test turned flaky -> Timeout on pkg-win-release bot.

Log: https://dart-ci.appspot.com/log/pkg-win-release/unittest-asserts-release-win/17883/pkg/dev_compiler/test/expression_compiler/expression_compiler_worker_test

This test is consistently timing out on pkg-linux-debug and pkg-win-release. It's flaky on pkg-linux-release and pkg-mac-release.

[annagrin]

@Markzipan looks like the expression compiler worker tests are flaky - would you be able to investigate?

Update: nevermind, I will look at them:)

[annagrin]

I could not repro a hang on my linux and windows machines, but from the logs it looks like the tests just take about 4 min so they could be just timing out.

[Markzipan]

@annagrin My bad, just saw this. I resolved this for the e2e tests by splitting them across module systems. That should suffice for fixing these timeouts a well (since it seems we're testing AMD and DDC together).

[annagrin]

@Markzipan thanks!

[annagrin]

fix pending in https://dart-review.googlesource.com/c/sdk/+/213734