Failures on [VM/runtime] Refactor the representation of type parameters in the VM.

[sstrickl]

There are new test failures on [VM/runtime] Refactor the representation of type parameters in the VM..

The tests

vm/dart/strict_null_safety_checks_in_weak_mode_test Crash (expected Pass)

are failing on configurations

dartk-weak-asserts-linux-debug-ia32
dartk-weak-asserts-linux-release-ia32

It's triggering a breakpoint in the NullIsAssignableToTypeNullSafe stub that happens if an AbstractType that isn't a Type, TypeParameter, or FunctionType is passed (so almost certainly a TypeRef in this case).

/cc @crelier

[sstrickl]

Since the following tests are also failing with a breakpoint trap, they are almost certainly the same. Will git bisect one or two to confirm:

The tests

standalone/io/client_socket_add_close_error_test Crash (expected Pass)
standalone/io/client_socket_add_close_result_error_test Crash (expected Pass)
standalone/io/http_client_parser_crlfs_tolerant_test Crash (expected Pass)
standalone/io/http_connection_close_test Crash (expected Pass)
standalone/io/http_server_early_client_close2_test/0 Crash (expected Pass)
standalone/io/http_server_early_client_close2_test/1 Crash (expected Pass)
standalone/io/http_server_early_client_close_test/0 Crash (expected Pass)
standalone/io/http_server_early_client_close_test/1 Crash (expected Pass)
standalone/io/http_server_response_test/0 Crash (expected Pass)
standalone/io/http_server_response_test/1 Crash (expected Pass)
standalone/io/http_shutdown_test/0 Crash (expected Pass)
standalone/io/http_shutdown_test/1 Crash (expected Pass)
standalone/io/http_shutdown_test/2 Crash (expected Pass)
standalone/io/http_shutdown_test/3 Crash (expected Pass)
standalone/io/raw_secure_server_socket_test/0 Crash (expected Pass)
standalone/io/raw_secure_server_socket_test/1 Crash (expected Pass)
standalone/io/raw_server_socket_cancel_test/0 Crash (expected Pass)
standalone/io/raw_server_socket_cancel_test/1 Crash (expected Pass)
standalone/io/raw_server_socket_cancel_test/2 Crash (expected Pass)
standalone/io/raw_server_socket_cancel_test/3 Crash (expected Pass)
standalone/io/raw_socket_test/0 Crash (expected Pass)
standalone/io/raw_socket_test/1 Crash (expected Pass)
standalone/io/raw_socket_test/2 Crash (expected Pass)
standalone/io/raw_socket_test/3 Crash (expected Pass)
standalone/io/secure_server_client_certificate_test Crash (expected Pass)
vm/dart/regress_45270_test Crash (expected Pass)

are failing on configurations

dartk-strong-linux-debug-ia32
dartk-strong-linux-release-ia32

[sstrickl]

Picked standalone/io/http_connection_close_test and vm/dart/regress_45270_test out of the bunch, tried them on 8a21ab1 and the previous commit b3993c9, and they pass on the previous commit but not the TypeParameters change, so yes, these should all be related.

[sstrickl]

Also related:

The tests

language_2/generic_methods/closure_test Crash (expected Pass)

are failing on configurations

dartk-reload-linux-debug-x64
dartk-reload-rollback-linux-debug-x64

[a-siva]

//cc @crelier

[crelier]

Tess, thanks for filing this issue. The type causing the int3 is not a TypeRef, but a Smi, which is really weird. I have not yet understood why a Smi shows up as a type, and only on ia32.