Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Socket.setOption fails for sockets with addresses of type InternetAddressType.unix #45975

Closed
robert-ancell opened this issue May 10, 2021 · 1 comment
Closed

Socket.setOption fails for sockets with addresses of type InternetAddressType.unix #45975

robert-ancell opened this issue May 10, 2021 · 1 comment
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.

Comments

@robert-ancell
Copy link
Contributor

robert-ancell commented May 10, 2021 •
edited
Loading

If you attempt to set a a socket option when using a Unix socket the following is printed on the console:

Value outside expected range

This is due to the following code, which was written when Unix sockets didn't exist.

  int64_t protocol = DartUtils::GetInt64ValueCheckRange(
      Dart_GetNativeArgument(args, 2), SocketAddress::TYPE_IPV4,
      SocketAddress::TYPE_IPV6);
This was referenced May 10, 2021
Closed
Closed
@mit-mit mit-mit added the area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. label May 11, 2021
@a-siva
Copy link
Contributor

a-siva commented May 13, 2021

https://dart-review.googlesource.com/c/sdk/+/199640

dart-bot pushed a commit that referenced this issue May 14, 2021
@a-siva
[dart:io] - Fix incorrect setting of socket options for UNIX-DOMAIN s…
fb90f11 
…ockets

- setting of UNIX-DOMAIN socket options was not throwing the correct error
- listen in HTTPServer was trying to set TCP_NODELAY for UNIX-DOMAIN sockets

Fixes :
 #45977
 #45978
 #45975

TEST=new test cases added

Change-Id: Ie0341f26b1ba0f9423c08a8de968053a2af1c730
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/199640
Commit-Queue: Siva Annamalai <asiva@google.com>
Reviewed-by: Alexander Aprelev <aam@google.com>
@a-siva a-siva closed this as completed May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.
Projects
None yet
Milestone
No milestone
3 participants
@robert-ancell @a-siva @mit-mit