Don't set TCP_NO_DELAY socket option for Unix sockets. #45978
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not supported for this socket type and will generate a "Operation not supported" exception. Fixes dart-lang#45977
|
Thank you for the contribution. Gerrit review is at https://dart-review.googlesource.com/c/sdk/+/199122 Please add a regression test. Location for a test would be |
|
Thank you for your contribution @robert-ancell I have included your changes along with some test cases here https://dart-review.googlesource.com/c/sdk/+/199640 |
dart-bot
pushed a commit
that referenced
this pull request
May 14, 2021
…ockets - setting of UNIX-DOMAIN socket options was not throwing the correct error - listen in HTTPServer was trying to set TCP_NODELAY for UNIX-DOMAIN sockets Fixes : #45977 #45978 #45975 TEST=new test cases added Change-Id: Ie0341f26b1ba0f9423c08a8de968053a2af1c730 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/199640 Commit-Queue: Siva Annamalai <asiva@google.com> Reviewed-by: Alexander Aprelev <aam@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not supported for this socket type and will generate a "Operation not supported" exception.
Fixes #45977