Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dart analyze crashes after reporting "No issues found!". #48584

Closed
chandarrengoog opened this issue Mar 16, 2022 · 9 comments
Closed

dart analyze crashes after reporting "No issues found!". #48584

chandarrengoog opened this issue Mar 16, 2022 · 9 comments
Labels
area-dart-cli Use area-dart-cli for issues related to the 'dart' command like tool. area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. P1 A high priority bug; for example, a single project is unusable or has many test failures type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@chandarrengoog
Copy link
Contributor

It seems that https://dart-review.googlesource.com/c/sdk/+/234660 has inadvertently caused crashes even when the analylzer says "No issues found!".

See #48413 for additional context.

See https://logs.chromium.org/logs/turquoise/buildbucket/cr-buildbucket/8819654207538277009/+/u/build/failure_summary and https://chat.google.com/room/AAAABFiUm4o/iCzaNBjqgdY for the crash.

CC: @srawlins, @rmacnak-google
@chandarrengoog chandarrengoog added P1 A high priority bug; for example, a single project is unusable or has many test failures area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. analyzer-server analyzer-stability type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) area-dart-cli Use area-dart-cli for issues related to the 'dart' command like tool. dart-cli-analyze Issues related to the 'dart analyze' tool labels Mar 16, 2022
@chandarrengoog chandarrengoog mentioned this issue Mar 16, 2022
Closed
@srawlins
Copy link
Member

The situation fixed in https://dart-review.googlesource.com/c/sdk/+/234660 is that a crash occurs, and then the process hangs. I fixed it so that the crash still occurs, and the process exits. Are you saying that change introduced a second crash?

@srawlins
Copy link
Member

As the analysis_server crashes, this is a bug either with the Dart VM, or with fsatrace. @rmacnak-google asserts it is a bug with fsatrace.

@srawlins srawlins added area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. and removed area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. analyzer-server analyzer-stability dart-cli-analyze Issues related to the 'dart analyze' tool labels Mar 16, 2022
@chandarrengoog
Copy link
Contributor Author

The situation fixed in https://dart-review.googlesource.com/c/sdk/+/234660 is that a crash occurs, and then the process hangs. I fixed it so that the crash still occurs, and the process exits. Are you saying that change introduced a second crash?

I think so, since the dart analyzer consistently fails our builds now. Except this second crash happens specifically happens after the dart analyzer logs "No issues found!" to stdout.

@srawlins
Copy link
Member

Ah I see. Thanks for clarifying. How can I reproduce this?

@chandarrengoog
Copy link
Contributor Author

In the past this has been flakey in infra and locally, but since this is reproducing more often in infra I'll see if I can try to get a clear local repro case.

@woody77
Copy link

woody77 commented Mar 16, 2022

Do we get any sort of a stack trace from the crashing of fsatrace + dart?

@jwren
Copy link
Member

jwren commented Mar 17, 2022

CC @bwilkerson @jwren

@srawlins -- What is the status with this issue? LMK if I can be of any help.

@chandarrengoog
Copy link
Contributor Author

There's no stack trace available, but I suspect the issue is that the analysis server shutdown timeout is too short. I'm testing this theory out and will upload a CL if that ends up being the case.

@chandarrengoog
Copy link
Contributor Author

Just sent out https://dart-review.googlesource.com/c/sdk/+/237780 which should fix the issue. Thanks @chaselatta for helping me figure this out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-dart-cli Use area-dart-cli for issues related to the 'dart' command like tool. area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. P1 A high priority bug; for example, a single project is unusable or has many test failures type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@srawlins @jwren @woody77 @chandarrengoog