Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failures on [dart2js] Migrate more of entities.dart...[parser] Rename Token impl classes to avoid name conflicts #48847

Closed
alexmarkov opened this issue Apr 20, 2022 · 1 comment
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. gardening

Comments

@alexmarkov
Copy link
Contributor

There are new test failures on [dart2js] Migrate more of entities.dart...[parser] Rename Token impl classes to avoid name conflicts.

The tests

vm/dart_2/isolates/reload_many_isolates_live_and_die_test Timeout (expected Pass)

are failing on configurations

dartk-reload-linux-release-x64

This test seems to be very slow and has flaky timeouts on other configurations (dartk-linux-release-simarm, dartk-tsan-linux-release-x64, dartk-linux-release-simarm64, dartk-mac-release-x64, dartk-reload-rollback-linux-release-x64).

@mkustermann Is it possible to reduce the amount of work performed in this test without loosing test coverage? Or maybe we should SkipSlow the test on all these configurations?

@alexmarkov alexmarkov added area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. gardening labels Apr 20, 2022
@mkustermann
Copy link
Member

For our artificial hot-reload test mode: The test itself launches subprocesses and performs reload on them. We don't need the test driver itself to run in this artificial identical hot reload mode.

For simulators: We can reduce the load.

For others: We should give it a little more time. e.g. the TSAN mode adds value (running it locally already revealed an issue: #48871)

-> cl/242107

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. gardening
Projects
None yet
Development

No branches or pull requests

2 participants