Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cfe/ffi] pkg/front_end/test/ffi_test.dart #49304

Open
dcharkes opened this issue Jun 21, 2022 · 1 comment
Open

[cfe/ffi] pkg/front_end/test/ffi_test.dart #49304

dcharkes opened this issue Jun 21, 2022 · 1 comment
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-ffi

Comments

@dcharkes
Copy link
Contributor

pkg/front_end/messages.yaml points to pkg/front_end/test/ffi_test.dart as its test, but we don't do any tests.

Instead of testing in the CFE way, we have tests expecting compile-time errors in tests/ffi/vmspecific_static_checks_test.dart.

We could consider adding CFE tests or making FFI messages exempt from that test flow.

@dcharkes dcharkes added area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-ffi labels Jun 21, 2022
@dcharkes
Copy link
Contributor Author

2 Options proposed by @johnniwinther in https://dart-review.googlesource.com/c/sdk/+/249301

  • I think we should just remove 'ffi_test.dart' and the external: test/ffi_test.dart entries in 'messages.yaml' and instead add an entry in 'messages.status' to allow the messages to have no example.
  • Better yet, would be to add an example that triggers the message - this is the real benefit of the 'example:' entries in messages.yaml; that we can test that the exact message is triggered by the example. If it is not possible to trigger the message through an example, we should work towards making it possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-ffi
Projects
None yet
Development

No branches or pull requests

1 participant