Failures on [vm] Skip filtered class earlier in source report....[analysis_server] Add a user setting to control verbosity of dartdocs in LSP hovers and related responses

[alexmarkov]

There are new test failures on [vm] Skip filtered class earlier in source report....[analysis_server] Add a user setting to control verbosity of dartdocs in LSP hovers and related responses.

The tests

pkg/vm_service/test/source_report_package_filters_test RuntimeError (expected Pass)

are failing on configurations

unittest-asserts-debug-linux

>testee>err> ../../runtime/vm/source_report.cc: 243: error: expected: script_table_entries_.length() == next_script_index_
>testee>err> version=2.19.0-edge.86233b55bcc87832f32f944485d5cb841c564fee (be) (Mon Oct 31 20:55:53 2022 +0000) on "linux_x64"
>testee>err> pid=5258, thread=5371, isolate_group=main(0x556ded498000), isolate=main(0x556ded50e000)
>testee>err> os=linux, arch=x64, comp=no, sim=no
>testee>err> isolate_instructions=556debf26ae0, vm_instructions=556debf26ae0
>testee>err>   pc 0x0000556dec33cecc fp 0x00007f697947c560 dart::Profiler::DumpStackTrace(void*)+0x7c
>testee>err>   pc 0x0000556debf26cd4 fp 0x00007f697947c640 dart::Assert::Fail(char const*, ...) const+0x84
>testee>err>   pc 0x0000556dec3dd08b fp 0x00007f697947c6b0 out/DebugX64/dart-sdk/bin/dart+0x256008b
>testee>err>   pc 0x0000556dec3e067c fp 0x00007f697947c750 dart::SourceReport::CollectConstConstructorCoverageFromScripts(dart::GrowableArray<dart::SourceReport::ScriptTableEntry*>*, dart::JSONArray*)+0x16c
>testee>err>   pc 0x0000556dec3dff93 fp 0x00007f697947c800 dart::SourceReport::PrintJSON(dart::JSONStream*, dart::Script const&, dart::TokenPosition, dart::TokenPosition)+0x363
>testee>err>   pc 0x0000556dec3cb635 fp 0x00007f697947c960 out/DebugX64/dart-sdk/bin/dart+0x254e635
>testee>err>   pc 0x0000556dec3c0e0d fp 0x00007f697947cf70 dart::Service::InvokeMethod(dart::Isolate*, dart::Array const&, bool)+0x4ed
>testee>err>   pc 0x0000556dec3c190e fp 0x00007f697947cfa0 dart::Service::HandleIsolateMessage(dart::Isolate*, dart::Array const&)+0x1e
>testee>err>   pc 0x0000556dec1bda7f fp 0x00007f697947d540 dart::IsolateMessageHandler::HandleMessage(std::__2::unique_ptr<dart::Message, std::__2::default_delete<dart::Message>>)+0x29f
>testee>err>   pc 0x0000556dec1ff1a4 fp 0x00007f697947d5d0 dart::MessageHandler::HandleMessages(dart::MonitorLocker*, bool, bool)+0x214
>testee>err>   pc 0x0000556dec1ff8b0 fp 0x00007f697947d630 dart::MessageHandler::HandleOOBMessages()+0xb0
>testee>err>   pc 0x0000556dec87f314 fp 0x00007f697947d6c0 Dart_HandleServiceMessages+0x134
>testee>err>   pc 0x0000556dec1c55dd fp 0x00007f697947d710 dart::Isolate::PauseEventHandler()+0xad
>testee>err>   pc 0x0000556dec18b7ba fp 0x00007f697947d8c0 dart::Debugger::Pause(dart::ServiceEvent*)+0xba
>testee>err>   pc 0x0000556dec1992aa fp 0x00007f697947da10 dart::Debugger::SignalPausedEvent(dart::ActivationFrame*, dart::Breakpoint*)+0xaa
>testee>err>   pc 0x0000556dec19959b fp 0x00007f697947da70 dart::Debugger::PauseStepping()+0x25b
>testee>err>   pc 0x0000556dec3ab614 fp 0x00007f697947dfa0 dart::DRT_SingleStepHandler(dart::NativeArguments)+0x174
>testee>err>   pc 0x00007f6986c02b82 fp 0x00007f697947dfe0 Unknown symbol
>testee>err>   pc 0x00007f6986c0307e fp 0x00007f697947e000 Unknown symbol
>testee>err>   pc 0x00007f698012be66 fp 0x00007f697947e030 Unknown symbol
>testee>err>   pc 0x00007f698012bcb9 fp 0x00007f697947e058 Unknown symbol
>testee>err>   pc 0x00007f698012b43f fp 0x00007f697947e0e0 Unknown symbol
>testee>err>   pc 0x00007f6980128882 fp 0x00007f697947e1b0 Unknown symbol
>testee>err>   pc 0x00007f698012725e fp 0x00007f697947e210 Unknown symbol
>testee>err>   pc 0x00007f69801270e7 fp 0x00007f697947e260 Unknown symbol
>testee>err>   pc 0x00007f698012625f fp 0x00007f697947e2c8 Unknown symbol
>testee>err>   pc 0x00007f69801264bd fp 0x00007f697947e300 Unknown symbol
>testee>err>   pc 0x00007f698012625f fp 0x00007f697947e368 Unknown symbol
>testee>err>   pc 0x00007f6980125ac0 fp 0x00007f697947e3b8 Unknown symbol
>testee>err>   pc 0x00007f6986c0300a fp 0x00007f697947e430 Unknown symbol
>testee>err>   pc 0x0000556dec18508d fp 0x00007f697947e4c0 dart::DartEntry::InvokeCode(dart::Code const&, unsigned long, dart::Array const&, dart::Array const&, dart::Thread*)+0xfd
>testee>err>   pc 0x0000556dec184cd9 fp 0x00007f697947e530 dart::DartEntry::InvokeFunction(dart::Function const&, dart::Array const&, dart::Array const&, unsigned long)+0x159
>testee>err>   pc 0x0000556dec187c1b fp 0x00007f697947e590 dart::DartLibraryCalls::HandleMessage(long, dart::Instance const&)+0x10b
>testee>err>   pc 0x0000556dec1bdb92 fp 0x00007f697947eb30 dart::IsolateMessageHandler::HandleMessage(std::__2::unique_ptr<dart::Message, std::__2::default_delete<dart::Message>>)+0x3b2
>testee>err>   pc 0x0000556dec1ff1a4 fp 0x00007f697947ebc0 dart::MessageHandler::HandleMessages(dart::MonitorLocker*, bool, bool)+0x214
>testee>err>   pc 0x0000556dec1fff23 fp 0x00007f697947ec40 dart::MessageHandler::TaskCallback()+0x333
>testee>err>   pc 0x0000556dec4004f0 fp 0x00007f697947ecd0 dart::ThreadPool::WorkerLoop(dart::ThreadPool::Worker*)+0x1e0
>testee>err>   pc 0x0000556dec400e6a fp 0x00007f697947ed20 dart::ThreadPool::Worker::Main(unsigned long)+0x14a
>testee>err>   pc 0x0000556dec336022 fp 0x00007f697947ee70 out/DebugX64/dart-sdk/bin/dart+0x24b9022
>testee>err> -- End of DumpStackTrace
>testee>err>   pc 0x0000000000000000 fp 0x00007f697947dfe0 sp 0x0000000000000000 [Stub] CallToRuntime
>testee>err>   pc 0x00007f6986c0307e fp 0x00007f697947e000 sp 0x00007f697947dff0 [Stub] DebugStepCheck
>testee>err>   pc 0x00007f698012be66 fp 0x00007f697947e030 sp 0x00007f697947e010 [Unoptimized] testFunction
>testee>err>   pc 0x00007f698012bcb9 fp 0x00007f697947e058 sp 0x00007f697947e040 [Unoptimized] testFunction
>testee>err>   pc 0x00007f698012b43f fp 0x00007f697947e0e0 sp 0x00007f697947e068 [Unoptimized] _ServiceTesteeRunner@23484714.run
>testee>err>   pc 0x00007f6980128882 fp 0x00007f697947e1b0 sp 0x00007f697947e0f0 [Unoptimized] runIsolateTests
>testee>err>   pc 0x00007f698012725e fp 0x00007f697947e210 sp 0x00007f697947e1c0 [Unoptimized] main
>testee>err>   pc 0x00007f69801270e7 fp 0x00007f697947e260 sp 0x00007f697947e220 [Unoptimized] main
>testee>err>   pc 0x00007f698012625f fp 0x00007f697947e2c8 sp 0x00007f697947e270 [Unoptimized] _Closure@0150898.dyn:call
>testee>err>   pc 0x00007f69801264bd fp 0x00007f697947e300 sp 0x00007f697947e2d8 [Unoptimized] _delayEntrypointInvocation@1026248.<anonymous closure>
>testee>err>   pc 0x00007f698012625f fp 0x00007f697947e368 sp 0x00007f697947e310 [Unoptimized] _Closure@0150898.dyn:call
>testee>err>   pc 0x00007f6980125ac0 fp 0x00007f697947e3b8 sp 0x00007f697947e378 [Unoptimized] _RawReceivePortImpl@1026248._handleMessage@1026248
>testee>err>   pc 0x00007f6986c0300a fp 0x00007f697947e430 sp 0x00007f697947e3c8 [Stub] InvokeDartCode

Full log: https://dart-ci.appspot.com/log/pkg-linux-debug/unittest-asserts-debug-linux/15758/pkg/vm_service/test/source_report_package_filters_test

Most likely caused by 86233b5.
@liamappelbe Could you take a look?