Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dartdevc should throw TypeError, not NullThrownError #50598

Closed
whesse opened this issue Dec 1, 2022 · 4 comments
Closed

Dartdevc should throw TypeError, not NullThrownError #50598

whesse opened this issue Dec 1, 2022 · 4 comments
Assignees
@nshahan
Labels
area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. dev-compiler-errors dev-compiler-test P2 A bug or feature request we're likely to work on web-dev-compiler

Comments

@whesse
Copy link
Contributor

whesse commented Dec 1, 2022

Two tests have been changed to check this, and are now failing on dartdevc

✔ co19/Language/Expressions/Throw/evaluation_t04
✔ co19/LibTest/async/Future/Future.sync_A01_t03

The issue about this change is dart-lang/co19#1553
@keertip keertip added the area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. label Dec 1, 2022
@nshahan nshahan self-assigned this Dec 1, 2022
@nshahan
Copy link
Contributor

nshahan commented Dec 2, 2022

@whesse I don't see any failures yet, and I don't expect them to fail because in DDC NullThrownError is a TypeError. Where did you see the failure?

@whesse
Copy link
Contributor Author

whesse commented Dec 2, 2022

The failures are on the result feed, where they are approved,

https://dart-ci.firebaseapp.com/#test=co19/LibTest/async/Future/Future.sync_A01_t03

They are also on the current results ui:

https://dart-ci.firebaseapp.com/current_results/#/filter=co19/Language/Expressions/Throw/evaluation_t04,co19/LibTest/async/Future/Future.sync_A01_t03

@nshahan
Copy link
Contributor

nshahan commented Dec 2, 2022

Ahhh the ddc canary configuration. Thanks!

@nshahan nshahan added the P2 A bug or feature request we're likely to work on label Dec 3, 2022
@nshahan
Copy link
Contributor

nshahan commented Dec 3, 2022

Waiting for the go ahead to land and clarification on the breaking change.
#49141

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nshahan nshahan

Labels
area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. dev-compiler-errors dev-compiler-test P2 A bug or feature request we're likely to work on web-dev-compiler
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sigmundch @keertip @nshahan @whesse