Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handful of test crashes on IA32/ARM64/RISCV64 after removal of dartdev.dill #50706

Closed
sstrickl opened this issue Dec 13, 2022 · 3 comments
Closed
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. gardening

Comments

@sstrickl
Copy link
Contributor

There are new test failures on [VM/CLI] Remove dartdev.dill.

The tests

ffi/regress_47594_test Crash (expected Pass)
ffi_2/regress_47594_test Crash (expected Pass)
standalone/check_for_aot_snapshot_jit_test RuntimeError (expected Pass)
standalone/regress_41329_absolute_test RuntimeError (expected Pass)
standalone/regress_41329_relative_test RuntimeError (expected Pass)
standalone_2/check_for_aot_snapshot_jit_test RuntimeError (expected Pass)
standalone_2/regress_41329_absolute_test RuntimeError (expected Pass)
standalone_2/regress_41329_relative_test RuntimeError (expected Pass)

are failing on configurations

dartk-linux-debug-ia32
dartk-linux-release-arm64
dartk-linux-release-ia32
dartk-linux-release-simarm64
dartk-optcounter-linux-release-ia32
dartk-strong-linux-debug-ia32
dartk-strong-linux-debug-simriscv64
dartk-strong-linux-release-ia32
dartk-strong-linux-release-simarm64
dartk-weak-asserts-linux-debug-ia32
dartk-weak-asserts-linux-debug-simriscv64
dartk-weak-asserts-linux-release-ia32
dartk-weak-asserts-linux-release-simarm64

Looking into some of the crashes, it looks like dartdev.dart.snapshot isn't being recognized as an appjit snapshot when these tests try to load it, then causing them to crash (or fail due to subprocesses crashing) as the isolates aren't set up correctly.

Interestingly enough, it's not all architectures, it's just IA32/ARM64/RISCV64, and only a handful of tests, so not reverting the original change yet. However, if the fix can't be found quickly, perhaps we should revert until we do have the fix in place.

/cc @bkonyi @derekxu16

@sstrickl sstrickl added area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. gardening labels Dec 13, 2022
@sstrickl
Copy link
Contributor Author

Namely, the appjit_magic_number comparison below is failing:

if (memcmp(&header[0], appjit_magic_number.bytes,

@derekxu16
Copy link
Member

Reverted in 53d859f

@a-siva
Copy link
Contributor

a-siva commented Dec 21, 2022

Closing this as the change has been reverted.

@a-siva a-siva closed this as completed Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. gardening
Projects
None yet
Development

No branches or pull requests

3 participants