Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failures on Revert "[vm] Migrate FFI callbacks to the new metadata system."...[ddc] Fix for record types with new type system #52581

Closed
aam opened this issue Jun 1, 2023 · 1 comment
Assignees
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. gardening

Comments

@aam
Copy link
Contributor

aam commented Jun 1, 2023

There are new test failures on Revert "[vm] Migrate FFI callbacks to the new metadata system."...[ddc] Fix for record types with new type system.

The tests

ffi/vmspecific_function_callbacks_exit_test/03/0 Fail (expected Pass)
ffi/vmspecific_function_callbacks_exit_test/03/1 Fail (expected Pass)

are failing on configurations

vm-aot-linux-release-arm-qemu
vm-aot-linux-release-riscv64-qemu
vm-aot-linux-release-x64
vm-aot-obfuscate-linux-release-x64
vm-eager-optimization-linux-release-ia32
vm-eager-optimization-linux-release-x64
vm-linux-debug-x64
vm-linux-release-arm-qemu
vm-linux-release-arm64
vm-linux-release-riscv64-qemu
vm-linux-release-x64
vm-reload-linux-release-x64
vm-reload-rollback-linux-release-x64
@aam aam added area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. gardening labels Jun 1, 2023
@liamappelbe
Copy link
Contributor

This test was failing before my original CL, then my CL caused it to start passing, and now the rollback has caused it to fail again: https://dart-ci.firebaseapp.com/#showLatestFailures=false&test=ffi/vmspecific_function_callbacks_exit_test/03/1&configurations=vm-linux-debug-x64

I'm going to reland this CL soonish, so the tests should start passing again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. gardening
Projects
None yet
Development

No branches or pull requests

2 participants