New vm/dart/comparison_canonicalization_il_test fails on dartkp-weak-asserts-linux-release-x64, vm-aot-obfuscate-linux-release-x64

[sstrickl]

There are new test failures on [vm/compiler] Improve flow sensitivity of CP.

The tests

vm/dart/comparison_canonicalization_il_test Crash (expected Pass)

are failing on configurations

dartkp-weak-asserts-linux-release-x64
vm-aot-obfuscate-linux-release-x64

Log for dartkp-weak-asserts-linux-release-x64:

--- Command "compare_il" (took 02.000281s):
DART_CONFIGURATION=ReleaseX64 /b/s/w/ir/pkg/vm/tool/compare_il /b/s/w/ir/runtime/tests/vm/dart/comparison_canonicalization_il_test.dart /b/s/w/ir/out/ReleaseX64/generated_compilations/dartkp-weak-asserts-linux-release-x64/runtime_tests_vm_dart_comparison_canonicalization_il_test/out.il

exit code:
255

stdout:
matching IL (After AllocateRegisters) for strictCompareValueNeConstant
... ok
matching IL (After AllocateRegisters) for strictCompareValueEqConstant
... ok
matching IL (After AllocateRegisters) for equalityCompareValueEqConstant
... ok
matching IL (After AllocateRegisters) for strictCompareBoolNeTrue
Failed to match: Unmatched instruction: Return({i: [true]}) in block B3
B0[GraphEntry]
  v3 <- Constant[value: true]()
  v8 <- Constant[value: false]()
B1[FunctionEntry]
  v2 <- Parameter[index: 0]()
  ParallelMove()
  Branch if StrictCompare[kind: !==](v2, v3) then  goto [3, 4]
B3[TargetEntry]
  ParallelMove()
  AssertBoolean(v2)
  ParallelMove()
  v6 <- BooleanNegate(v2)
  ParallelMove()
  Return(v6)
B4[TargetEntry]
  ParallelMove()
  Return(v8)

stderr:
Unhandled exception:
Failed to match
#0      FlowGraph.match (package:vm/testing/il_matchers.dart:45:9)
#1      matchIL$strictCompareBoolNeTrue (file:///b/s/w/ir/runtime/tests/vm/dart/comparison_canonicalization_il_test.dart:203:9)
#2      _LibraryMirror._invoke (dart:mirrors-patch/mirrors_impl.dart:999:68)
#3      _ObjectMirror.invoke (dart:mirrors-patch/mirrors_impl.dart:248:25)
#4      TestCase.run (file:///b/s/w/ir/pkg/vm/bin/compare_il.dart:65:13)
#5      main (file:///b/s/w/ir/pkg/vm/bin/compare_il.dart:39:10)
<asynchronous suspension>

--- Re-run this test:
python3 tools/test.py -n dartkp-weak-asserts-linux-release-x64 vm/dart/comparison_canonicalization_il_test

Log for vm-aot-obfuscate-linux-release-x64:

--- Command "compare_il" (took 02.000668s):
DART_CONFIGURATION=ReleaseX64 /b/s/w/ir/cache/builder/sdk/pkg/vm/tool/compare_il /b/s/w/ir/cache/builder/sdk/runtime/tests/vm/dart/comparison_canonicalization_il_test.dart /b/s/w/ir/cache/builder/sdk/out/ReleaseX64/generated_compilations/vm-aot-obfuscate-linux-release-x64/runtime_tests_vm_dart_comparison_canonicalization_il_test/out.il /b/s/w/ir/cache/builder/sdk/out/ReleaseX64/generated_compilations/vm-aot-obfuscate-linux-release-x64/runtime_tests_vm_dart_comparison_canonicalization_il_test/renames.json

exit code:
255

stdout:
matching IL (After AllocateRegisters) for strictCompareValueNeConstant
Failed to match: Unmatched instruction: A(0) <- Constant({d: {value: Instance of A}}) in block B0
B0[GraphEntry]
  v3 <- Constant[value: Instance of Ck]()
  v16 <- UnboxedConstant[value: 0]()
  v19 <- UnboxedConstant[value: 42]()
B1[FunctionEntry]
  v2 <- Parameter[index: 0]()
  ParallelMove()
  Branch if StrictCompare[kind: !==](v2, v3) then  goto [3, 4]
B3[TargetEntry]
  ParallelMove()
  Return(v19)
B4[TargetEntry]
  ParallelMove()
  Return(v16)

stderr:
Unhandled exception:
Failed to match
#0      FlowGraph.match (package:vm/testing/il_matchers.dart:45:9)
#1      matchIL$strictCompareValueNeConstant (file:///b/s/w/ir/cache/builder/sdk/runtime/tests/vm/dart/comparison_canonicalization_il_test.dart:103:9)
#2      _LibraryMirror._invoke (dart:mirrors-patch/mirrors_impl.dart:999:68)
#3      _ObjectMirror.invoke (dart:mirrors-patch/mirrors_impl.dart:248:25)
#4      TestCase.run (file:///b/s/w/ir/cache/builder/sdk/pkg/vm/bin/compare_il.dart:65:13)
#5      main (file:///b/s/w/ir/cache/builder/sdk/pkg/vm/bin/compare_il.dart:39:10)
<asynchronous suspension>

--- Re-run this test:
python3 tools/test.py -n vm-aot-obfuscate-linux-release-x64 vm/dart/comparison_canonicalization_il_test

/cc @mraleph