Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[analysis_server] Shouldn't include dev dependencies in suggestions within /bin #54684

Closed
parlough opened this issue Jan 20, 2024 · 3 comments
Closed

[analysis_server] Shouldn't include dev dependencies in suggestions within /bin #54684

parlough opened this issue Jan 20, 2024 · 3 comments
Labels
analyzer-completion Issues with the analysis server's code completion feature analyzer-server area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P3 A lower priority bug or feature request

Comments

@parlough
Copy link
Member

The analysis server includes dev dependencies in completion suggestions within the /bin directory, but correctly does not within /lib. It should not include them for /bin either.

Tested on 3.2.5 and current main: cb16f98

Reproduced with IJ and VSCode.
@parlough parlough added area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. analyzer-completion Issues with the analysis server's code completion feature analyzer-server labels Jan 20, 2024
@srawlins
Copy link
Member

Oooh love it. Or anywhere outside lib/.

@srawlins srawlins added the P3 A lower priority bug or feature request label Jan 25, 2024
@parlough
Copy link
Member Author

parlough commented Jan 25, 2024 •
edited
Loading

Or anywhere outside lib/.

@srawlins Could you clarify what you mean? Maybe you misspecified 😄. They shouldn't be (and aren't) suggested in /lib either :)

@srawlins
Copy link
Member

Ah I see. Yes, they should not be suggested for files in bin/. Your original description is accurate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
analyzer-completion Issues with the analysis server's code completion feature analyzer-server area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P3 A lower priority bug or feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@srawlins @parlough