Compilation error after applying quick fix for prefer_is_empty linter rule

[aemelyanovff]

Consider this code:

bool isEmptyNotNull(List<String>? nullableList) {
  return nullableList?.length == 0;
}

The prefer_is_empty linter report reports a warning: Use 'isEmpty' instead of 'length' to test whether the collection is empty. Try rewriting the expression to use 'isEmpty'. When you apply the proposed fix, e.g. by running dart fix --apply, the result is

bool isEmptyNotNull(List<String>? nullableList) {
  return nullableList.isEmpty;
}

which fails to compile with The property 'isEmpty' can't be unconditionally accessed because the receiver can be 'null'.

Expected behavior: if code compiles before dart fix then it should compile after.

• Dart version and tooling diagnostic info (dart info): 3.3.0 (stable) (Tue Feb 13 10:25:19 2024 +0000) on "macos_arm64"
• Whether you are using Windows, macOS, or Linux (if applicable): macOS
• Whether you are using Chrome, Safari, Firefox, Edge (if applicable): N/A

[pq]

Great catch and awesome report. Thank you!