add library-level docs to help with importing #26330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * | ||
| * To use this library in your code: | ||
| * | ||
| * import 'dart:collection'; |
There was a problem hiding this comment.
Use
import 'dart:collection';please
There was a problem hiding this comment.
...meaning, triple-tick dart syntax
There was a problem hiding this comment.
Why?
All of the core libraries use indentation. The only exception seems to be uri.dart.
Tbh I don't mind either, but I wouldn't ask patches to the core libraries to use one or the other.
|
I just followed the previous convention. |
|
I'm encouraging a slow and steady move towards our current recommendation – but not a biggy |
|
Can we land as is and then change all at once in another PR? |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps with flutter/flutter#3119