Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.2] Mention NativeCallable in the ObjC multithreading limitations #5336

Merged
merged 3 commits into from
Nov 15, 2023

Conversation

liamappelbe
Copy link
Contributor

@liamappelbe liamappelbe commented Nov 13, 2023

Mention the new NativeCallable API in the ObjC multithreading limitations section. It's no longer true that all Dart callbacks will cause the app to crash when invoked from the wrong thread.

Fixes #5333

@liamappelbe liamappelbe marked this pull request as ready for review November 13, 2023 02:24
@liamappelbe
Copy link
Contributor Author

NativeCallable.isolateLocal links to an API reference that doesn't exist yet, because isolateLocal was only added in Dart 3.2. Is that a problem?

@parlough
Copy link
Member

parlough commented Nov 13, 2023

Thanks for updating this and the heads up!

I likely won't merge this until after the 3.2 stable API docs are available, so it should be fine :)

@parlough parlough self-assigned this Nov 13, 2023
@parlough parlough changed the title Mention NativeCallable in the ObjC multithreading limitations [3.2] Mention NativeCallable in the ObjC multithreading limitations Nov 13, 2023
@parlough parlough added the review.tech Awaiting Technical Review label Nov 13, 2023
@MaryaBelanger MaryaBelanger mentioned this pull request Nov 13, 2023
20 tasks
Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Liam!

@parlough parlough removed the review.tech Awaiting Technical Review label Nov 15, 2023
@parlough parlough merged commit e8abc23 into dart-lang:main Nov 15, 2023
8 checks passed
@parlough parlough mentioned this pull request Jan 24, 2024
atsansone pushed a commit to atsansone/site-www that referenced this pull request Jan 26, 2024
…dart-lang#5336)

Mention the new `NativeCallable` API in the ObjC multithreading
limitations section. It's no longer true that *all* Dart callbacks will
cause the app to crash when invoked from the wrong thread.

Fixes dart-lang#5333

---------

Co-authored-by: Parker Lougheed <parlough@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[3.2] Quick review of 'Objective-C and Swift interop using package:ffigen'
2 participants