Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide a means of accessing package assets from browser tests #27

Closed
nex3 opened this issue Feb 25, 2015 · 0 comments
Closed

Provide a means of accessing package assets from browser tests #27

nex3 opened this issue Feb 25, 2015 · 0 comments
Labels
type-enhancement A request for a change that isn't a bug
Milestone
1.0.0

Comments

@nex3
Copy link
Member

nex3 commented Feb 25, 2015

Once browser tests land, they won't have any support for accessing assets in the host package beyond the test file itself. One way or another, this access should be provided.
@nex3 nex3 added the type-enhancement A request for a change that isn't a bug label Feb 25, 2015
@nex3 nex3 modified the milestone: 1.0.0 Mar 31, 2015
nex3 added a commit that referenced this issue Apr 13, 2015
@nex3
Change the URL-space exposed by the browser server.
d2828ed 
This is a step towards Dartium support. Rather than only serving the compiled JS
and the HTML necessary to run it, the entire package is now served with the
compiled JS and HTML wrappers overlayed on top. This will allow Dartium to load
all necessary sources from the server, and incidentally also allows tests to
access assets.

See #60
Closes #27

R=kevmoo@google.com

Review URL: https://codereview.chromium.org//1076803003
@nex3 nex3 closed this as completed Apr 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
1 participant
@nex3