Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pddFlag removal + tests for pdd restricted instance of Analytics #86

Merged
merged 2 commits into from
May 2, 2023

Conversation

eliasyishak
Copy link
Contributor

@eliasyishak eliasyishak commented Apr 27, 2023

This PR is only focused on removing the flag that prevented the session and log files from being used. There will be a follow up PR that will add the functionality required on opt out which will clear these files.

Reference issue: #84

@eliasyishak
Copy link
Contributor Author

@jcollins-g friendly bump 😄

Copy link
Contributor

@jcollins-g jcollins-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Recommend merging after merging a change to clear out the files if possible; that way we are matched up with either v1 or v2 of the pdd at all commits.

@eliasyishak
Copy link
Contributor Author

LGTM. Recommend merging after merging a change to clear out the files if possible; that way we are matched up with either v1 or v2 of the pdd at all commits.

Yep good call, this tracking issue has the information for the other pull request to clear everything out #84

@eliasyishak eliasyishak merged commit b55f0d4 into dart-lang:main May 2, 2023
@eliasyishak eliasyishak deleted the pdd-revision-updates branch May 2, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants