move bindings_generator/ to tool/generator/ #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevmoo
approved these changes
Jan 11, 2024
|
Is there an easy way to reproduce the validation error? Sounds like something we want to fix. |
|
Yes, the project from this commit: has the previous directory structure. After a Essentially, I was expecting the top-level |
srujzs
added a commit
to srujzs/web
that referenced
this pull request
Jan 22, 2024
Generate extension type bindings Generate extension types instead of classes Refactors some code around overrides so we don't emit @js unless they're needed. Updates code_builder dep to 4.10.0 and dart_style to 2.3.4. Clean up JS supertype generation contribute a fix_data.yaml file to enable 'dart fix' renames (dart-lang#141) contribute a fix_data.yaml file to enable 'dart fix' renames collect MDN API information (dart-lang#130) collect MDN info for use in API documentation Redeprecate deprecated APIs in 0.4.1 (dart-lang#142) Undeprecate some APIs and prepare for publish of 0.4.2 (dart-lang#140) move bindings_generator/ to tool/generator/ (dart-lang#138) rev to 0.4.1 in preparation for publishing (dart-lang#135) Update generate copyright year to 2024 (dart-lang#136) Change-Id: I0f90fc08fd7871f8331f42c158cb7ba34e6bf887
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bindings_generator/totool/generator/pub publish validation complains about code in
bindings_generator/using dev_dependency deps instead of regular dependency deps; I don't believe it's correct (code in bindings_generator/ should not be contributing to regular deps) but this change will allow us to use publishing automation again.cc @jonasfj @sigurdm
Contribution guidelines:
dart format.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.