Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement setLibraryDebuggable #606

Open
grouma opened this issue Aug 22, 2019 · 0 comments
Open

Implement setLibraryDebuggable #606

grouma opened this issue Aug 22, 2019 · 0 comments
Labels
package:dwds type-enhancement A request for a change that isn't a bug

Comments

@grouma
Copy link
Member

grouma commented Aug 22, 2019

By default we currently black box the SDK and a couple other libraries:

webdev/dwds/lib/src/debugging/sources.dart

Line 181 in bba066f

Future<void> _blackBoxIfNecessary(WipScript script) async {

@grouma grouma mentioned this issue Aug 22, 2019
Closed
@grouma grouma added package:dwds type-enhancement A request for a change that isn't a bug labels Oct 15, 2019
DanTup added a commit to Dart-Code/Dart-Code that referenced this issue Nov 27, 2019
@DanTup
Reduce logging of setLibraryDebuggable
f504f1b 
Can be reverted when dart-lang/webdev#606 is done.
@DanTup DanTup mentioned this issue Apr 14, 2020
Closed
@DanTup DanTup mentioned this issue Jun 8, 2020
Closed
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Jun 14, 2022
@DanTup
[dds] Handle methodNotFound errors for setLibraryDebuggable for DWDS
3056251 
DWDS doesn't currently support this so the unhandled error will terminate the DAP when running under Flutter web:

dart-lang/webdev#606

Change-Id: I14f2dbffca66244268802924e347e2d70eec30a5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/248124
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
@DanTup DanTup mentioned this issue Oct 31, 2022
Closed
@DanTup DanTup mentioned this issue Jan 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package:dwds type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@grouma