Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed incorrect location for libraries.json and added test #1196

Merged

Conversation

annagrin
Copy link
Contributor

@annagrin annagrin commented Nov 20, 2020

Fixed incorrect location for libraries.json causing severe failure when running webdev with
--enable-expression-evaluation, added test to make sure expression compiler service can run its basic operations
with no errors.

Closes: #1195

Copy link
Member

@grouma grouma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this related to #1177 at all?

@annagrin
Copy link
Contributor Author

@grouma

Is this related to #1177 at all?

Not sure, It looks more like a ddc failure, but I would need more info. Left some questions on that thread.

@annagrin annagrin merged commit 91e3125 into dart-lang:master Nov 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Severe error is reported if running webdev with --enable-expression-evaluation
2 participants