Provide BuildResult #869
Merged
Provide BuildResult #869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakemac53
reviewed
Jan 10, 2020
| @@ -0,0 +1,31 @@ | |||
| // Copyright (c) 2020, the Dart project authors. Please see the AUTHORS file | |||
There was a problem hiding this comment.
Any chance we can get away from built_value? lol
There was a problem hiding this comment.
All of the other communication across the SSE channel is using built_value so I don't think it makes sense at this point in time.
jakemac53
approved these changes
Jan 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BuildResultabstraction insidepackage:dwdsand no longer rely on the one frompackage:build_daemon.Towards #865