Rework AssetHandler #870
Merged
Rework AssetHandler #870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakemac53
reviewed
Jan 15, 2020
| import 'dart:async'; | ||
|
|
||
| /// A handler for Dart sources and related source maps. | ||
| abstract class AssetHandler { |
There was a problem hiding this comment.
should we rename this to AssetReader or something since it no longer expose a Handler?
There was a problem hiding this comment.
Was initially planning on doing that but thought you wouldn't like it, so I left it as is. Should have chatted with you first. I'll clean this up.
jakemac53
approved these changes
Jan 16, 2020
| import 'asset_reader.dart'; | ||
|
|
||
| /// A reader for resources provided by build runner. | ||
| class BuildRunnerAssetReader implements AssetReader { |
There was a problem hiding this comment.
Consider ProxyServerAssetReader or something along those lines? It doesn't really have anything build-runner specific it just delegates the reads to a proxy server.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AssetHandlertoAssetReaderand move tosrc/readersAssetReaderAPI to make clear what resources need to be made available to DWDSBuildRunnerAssetHandlertoProxyServerAssetReaderProxyServerAssetReaderintoproxy_server_asset_reader.dartand move tosrc/readersFrontendServerAssetReaderwith similar functionalityreadAssetOrNulllogic intoProxyServerAssetReaderas it will likely not apply to theFrontendServerAssetReaderwebdevto adhere to the new API requirementsTowards #865