Frame size response
#42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@darth-cheney this looks good to me; I am sure something will surface but lets roll with it - merge whenever |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR deals with Issue #29, which points out how we are inconsistently giving the Frame
sizeacross the codebase.In this branch we are saying strictly that the
sizeof a Frame is a Point whose width and height values are equal to the length of the row and column arrays. Therefore, forFrame([0,0], [5,6]), the size isPoint([6, 7]).Implementation
The fix itself was small, but it had ramifications throughout the codebase and in the tests. I have dealt with all of the references I could find, and all tests seem to be passing
Remaining Work
I would like to include a specific test case for the example given in #29, once we have clarification of reproducing it.