Skip to content

Commit

Permalink
Suppress verbose warnings
Browse files Browse the repository at this point in the history
  • Loading branch information
jslee02 committed Jan 31, 2017
1 parent 7649006 commit 260ce8d
Show file tree
Hide file tree
Showing 7 changed files with 42 additions and 54 deletions.
2 changes: 2 additions & 0 deletions dart/gui/SimWindow.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,8 @@ namespace gui {

SimWindow::SimWindow()
: Win3D() {
mWorld = std::make_shared<simulation::World>();

mBackground[0] = 1.0;
mBackground[1] = 1.0;
mBackground[2] = 1.0;
Expand Down
3 changes: 3 additions & 0 deletions dart/utils/CompositeResourceRetriever.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,9 @@ common::ResourcePtr CompositeResourceRetriever::retrieve(
= getRetrievers(_uri);
for(const common::ResourceRetrieverPtr& resourceRetriever : retrievers)
{
if(!resourceRetriever->exists(_uri))
continue;

if(common::ResourcePtr resource = resourceRetriever->retrieve(_uri))
return resource;
}
Expand Down
49 changes: 33 additions & 16 deletions dart/utils/SampleResourceRetriever.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -54,14 +54,23 @@ bool SampleResourceRetriever::exists(const common::Uri& uri)
if (!resolveDataUri(uri, relativePath))
return false;

for (const auto& dataPath : mDataDirectories)
if (uri.mAuthority.get() == "sample")
{
common::Uri fileUri;
fileUri.fromPath(dataPath + relativePath);

if (mLocalRetriever->exists(fileUri))
for (const auto& dataPath : mDataDirectories)
{
common::Uri fileUri;
fileUri.fromPath(dataPath + relativePath);

if (mLocalRetriever->exists(fileUri))
return true;
}
}
else
{
if (mLocalRetriever->exists(uri))
return true;
}

return false;
}

Expand All @@ -72,14 +81,29 @@ common::ResourcePtr SampleResourceRetriever::retrieve(const common::Uri& uri)
if (!resolveDataUri(uri, relativePath))
return nullptr;

for (const auto& dataPath : mDataDirectories)
if (uri.mAuthority.get() == "sample")
{
common::Uri fileUri;
fileUri.fromPath(dataPath + relativePath);
for (const auto& dataPath : mDataDirectories)
{
common::Uri fileUri;
fileUri.fromPath(dataPath + relativePath);

if(!mLocalRetriever->exists(fileUri))
continue;

if (const auto resource = mLocalRetriever->retrieve(fileUri))
if (const auto resource = mLocalRetriever->retrieve(fileUri))
return resource;
}
}
else
{
if(!mLocalRetriever->exists(uri))
return nullptr;

if (const auto resource = mLocalRetriever->retrieve(uri))
return resource;
}

return nullptr;
}

Expand Down Expand Up @@ -110,13 +134,6 @@ bool SampleResourceRetriever::resolveDataUri(
if (uri.mScheme.get_value_or("file") != "file")
return false;

if (uri.mAuthority.get() != "sample")
{
dtwarn << "[SampleResourceRetriever::resolveDataUri] Invalid URI: The "
<< "authority of '" << uri.toString() << "' should be 'example'.\n";
return false;
}

if (!uri.mPath)
{
dtwarn << "[SampleResourceRetriever::resolveDataUri] Failed extracting"
Expand Down
3 changes: 1 addition & 2 deletions dart/utils/SampleResourceRetriever.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,7 @@ class SampleResourceRetriever : public common::ResourceRetriever

void addDataDirectory(const std::string& packageDirectory);

bool resolveDataUri(const common::Uri& uri,
std::string& relativePath) const;
bool resolveDataUri(const common::Uri& uri, std::string& relativePath) const;

private:
common::ResourceRetrieverPtr mLocalRetriever;
Expand Down
13 changes: 1 addition & 12 deletions dart/utils/SkelParser.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,6 @@
#include "dart/dynamics/Skeleton.hpp"
#include "dart/dynamics/Marker.hpp"
#include "dart/utils/XmlHelpers.hpp"
#include "dart/utils/CompositeResourceRetriever.hpp"
#include "dart/utils/SampleResourceRetriever.hpp"

namespace dart {
Expand Down Expand Up @@ -2408,19 +2407,9 @@ common::ResourceRetrieverPtr getRetriever(
const common::ResourceRetrieverPtr& _retriever)
{
if(_retriever)
{
return _retriever;
}
else
{
auto newRetriever = std::make_shared<utils::CompositeResourceRetriever>();
newRetriever->addSchemaRetriever(
"file", std::make_shared<common::LocalResourceRetriever>());
newRetriever->addSchemaRetriever(
"file", SampleResourceRetriever::create());

return newRetriever;
}
return SampleResourceRetriever::create();
}

} // anonymous namespace
Expand Down
13 changes: 1 addition & 12 deletions dart/utils/VskParser.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@
#include "dart/common/LocalResourceRetriever.hpp"
#include "dart/common/Uri.hpp"
#include "dart/dynamics/dynamics.hpp"
#include "dart/utils/CompositeResourceRetriever.hpp"
#include "dart/utils/SampleResourceRetriever.hpp"
#include "dart/utils/XmlHelpers.hpp"

Expand Down Expand Up @@ -1024,19 +1023,9 @@ common::ResourceRetrieverPtr getRetriever(
const common::ResourceRetrieverPtr& retriever)
{
if(retriever)
{
return retriever;
}
else
{
auto newRetriever = std::make_shared<utils::CompositeResourceRetriever>();
newRetriever->addSchemaRetriever(
"file", std::make_shared<common::LocalResourceRetriever>());
newRetriever->addSchemaRetriever(
"file", SampleResourceRetriever::create());

return newRetriever;
}
return SampleResourceRetriever::create();
}

} // anonymous namespace
Expand Down
13 changes: 1 addition & 12 deletions dart/utils/sdf/SdfParser.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,6 @@
#include "dart/simulation/World.hpp"
#include "dart/utils/SkelParser.hpp"
#include "dart/utils/XmlHelpers.hpp"
#include "dart/utils/CompositeResourceRetriever.hpp"
#include "dart/utils/SampleResourceRetriever.hpp"

namespace dart {
Expand Down Expand Up @@ -1490,19 +1489,9 @@ common::ResourceRetrieverPtr getRetriever(
const common::ResourceRetrieverPtr& retriever)
{
if(retriever)
{
return retriever;
}
else
{
auto newRetriever = std::make_shared<utils::CompositeResourceRetriever>();
newRetriever->addSchemaRetriever(
"file", std::make_shared<common::LocalResourceRetriever>());
newRetriever->addSchemaRetriever(
"file", SampleResourceRetriever::create());

return newRetriever;
}
return SampleResourceRetriever::create();
}

} // anonymous namespace
Expand Down

0 comments on commit 260ce8d

Please sign in to comment.