Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dartpy] Fix enabling drag and drop of InteractiveFrame #1432

Merged
merged 3 commits into from Jan 26, 2020

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented Jan 25, 2020

Enabling drag and drop for InteractiveFrame currently doesn't work as expected because of the order of Python bindings for dart::gui::osg::Viewer::enableDragAndDrop(...). pybind11 calls earlier-defined overloads. For InteractiveFrame case, enableDragAndDrop(Entity*) is called instead of enableDragAndDrop(InteractiveFrame*) because enableDragAndDrop(Entity*) is defined in prior to the other (and it's compatible since Entity is a base of InteractiveFrame). To prevent this, this PR defines enableDragAndDrop(InteractiveFrame*) (and other functions overloaded for derived classes of Entity) before enableDragAndDrop(Entity*).

dartpy_drag_and_drop


Before creating a pull request

  • Document new methods and classes
  • Format new code files using clang-format

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change

@jslee02 jslee02 added this to the DART 6.10.0 milestone Jan 25, 2020
@jslee02 jslee02 marked this pull request as ready for review January 25, 2020 01:40
@codecov
Copy link

codecov bot commented Jan 25, 2020

Codecov Report

Merging #1432 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1432      +/-   ##
==========================================
- Coverage      58%   57.99%   -0.02%     
==========================================
  Files         412      412              
  Lines       29861    29861              
==========================================
- Hits        17322    17319       -3     
- Misses      12539    12542       +3
Impacted Files Coverage Δ
dart/dynamics/Skeleton.cpp 66.16% <0%> (-0.17%) ⬇️

@jslee02 jslee02 merged commit 7aa73fe into master Jan 26, 2020
@jslee02 jslee02 deleted the dartpy/interactive_frame branch January 26, 2020 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant