Don't force CMAKE_INSTALL_PREFIX on windows #1478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes dartsim#1477. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
This was referenced Jul 25, 2020
Codecov Report
@@ Coverage Diff @@
## master #1478 +/- ##
==========================================
- Coverage 58.21% 58.20% -0.02%
==========================================
Files 412 412
Lines 29913 29913
==========================================
- Hits 17415 17412 -3
- Misses 12498 12501 +3
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1477.
Without this change, it ignores
CMAKE_INSTALL_PREFIXvalues specified by the user and always installs toC:/Golems.