Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shared/net: introduce AddrPort() helper #52

Merged
merged 2 commits into from
Feb 25, 2023
Merged

shared/net: introduce AddrPort() helper #52

merged 2 commits into from
Feb 25, 2023

Conversation

amery
Copy link
Contributor

@amery amery commented Feb 25, 2023

No description provided.

@amery
shared/net: turn one-case switch into an if to make revive happy
10c61b7 
Signed-off-by: Alejandro Mery <amery@jpi.io>
@amery amery requested a review from karasz February 25, 2023 21:22
karasz
karasz requested changes Feb 25, 2023
View reviewed changes
Copy link
Collaborator

@karasz karasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please enable back revive after the function name and if possible a comment of why the disable is needed would be nice

@amery
shared/net: add AddrPort() helper
f3e39a5 
Signed-off-by: Alejandro Mery <amery@jpi.io>
@amery
Copy link
Contributor Author

amery commented Feb 25, 2023

commit amended accordingly. I had neglected the revive:enable because it was the last function. but that can change inadvertently

@amery amery requested a review from karasz February 25, 2023 22:03
karasz
karasz approved these changes Feb 25, 2023
View reviewed changes
Copy link
Collaborator

@karasz karasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amery amery merged commit f3e39a5 into master Feb 25, 2023
@amery
Copy link
Contributor Author

amery commented Feb 25, 2023

shared/v0.1.2 tagged

@amery amery deleted the pr-amery-net branch February 25, 2023 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karasz karasz karasz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amery @karasz